Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CplSolver Unit Tests #11

Merged
merged 6 commits into from
Jul 13, 2021
Merged

CplSolver Unit Tests #11

merged 6 commits into from
Jul 13, 2021

Conversation

jb-mackay
Copy link
Contributor

  • Adds unit tests for the CplSolver
  • Adds callback storage to the CplModel struct

@LenkaNovak
Copy link
Collaborator

Looks great! Do we need L37-41 in cplstate_interface.jl, since we test units above and this is just overwriting the coupler field? Otherwise happy to merge! 👍

@jb-mackay
Copy link
Contributor Author

jb-mackay commented Jul 13, 2021 •
edited
Loading

Looks great! Do we need L37-41 in cplstate_interface.jl, since we test units above and this is just overwriting the coupler field? Otherwise happy to merge! 👍

Good catch @LenkaNovak, modified these lines so they act as intended.

@jb-mackay jb-mackay merged commit 95cb268 into main Jul 13, 2021
@jb-mackay jb-mackay deleted the bm/cplmodelsolver_tests branch July 28, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophernhill christophernhill Awaiting requested review from christophernhill

@LenkaNovak LenkaNovak Awaiting requested review from LenkaNovak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jb-mackay @LenkaNovak