SurfaceFluxes.jl plugin #24
Conversation
|
@charleskawczynski can I get your insight on why the Julia formatter is struggling here? |
|
Looking... |
|
These struct definitions are incomplete: struct Gravity{𝒯} <: AbstractGravity{𝒯}
struct Buoyancy{𝒯} <: AbstractGravity{𝒯} |
|
One nice trick with debugging formatter problems is opening the Julia REPL and trying to load the offending file. This often gives more informative error messages (since the formatter doesn't try to reason about the code in the same way that happens during code loading). |
|
@charleskawczynski does the JuliaFormatter action fail if the formatter hasn't been applied and then the formatted code committed? Or is this action failing for another reason? |
We're not currently depending on the success of the formatter (here), so we can merge this as is. If you'd like to apply the formatter for this PR, we could do that but, since the PR is already pretty large, the formatting could be applied in a separate PR (and then add the format entry in the bors toml file). |
|
bors r+ |
|
bors ping |
|
pong |
|
bors r+ |
24: SurfaceFluxes.jl plugin r=charleskawczynski a=LenkaNovak Provides a coupled test case that uses the dry Nishizawa & Kitamura (2018) formulation using `SurfaceFluxes.jl`. ## TODO: - [x] integrate to run with ClimaCore/ ClimaAtmos interface, ensuring type compatibility - [x] note changes in SF and NS + revamp the SurfaceFluxes.jl repo with original developers - [x] test for longer simtime and compare with the bulk formula test + conservation (conservation achieved) - [x] note if still conservation problems due to divergence operator - resolved (needed to apply boundary conditions only to diffusive fluxes, not advective fluxes as was the default) - [x] clean up `@shows` + document the SF functions (+ make README consistent) - [x] hook up to CI Rebased from [this](#19) PR. Co-authored-by: LenkaNovak <lenka@caltech.edu> Co-authored-by: Ben Mackay <jbmackay@caltech.edu>
|
bors r- |
|
Canceled. |
|
bors ping |
|
pong |
|
bors r+ |
|
Build succeeded: |
Provides a coupled test case that uses the dry Nishizawa & Kitamura (2018) formulation using
SurfaceFluxes.jl.TODO:
Rebased from this PR.