Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ozark conservation test for IMEX stepping #662

Open
Tracked by #809
juliasloan25 opened this issue Jun 13, 2024 · 0 comments
Open
Tracked by #809

Update ozark conservation test for IMEX stepping #662

juliasloan25 opened this issue Jun 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@juliasloan25
Copy link
Member

Is your feature request related to a problem? Please describe.
In #651, we convert the SoilCanopy model from being entirely explicitly-stepped to using explicit and implicit timestepping for different variables. This invalidates the conservation calculations we were previously using (see this link for more details).

We should re-think this test and update the calculations to accurately check conservation if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant