Use of similar in conditional_operations.jl

[navidcy]

The use of similar here drops the boundary conditions associated with c.operand. Is this dangerous?

Oceananigans.jl/src/AbstractOperations/conditional_operations.jl

Lines 127 to 131 in e394bf7

	function concretize_condition(c::ConditionalOperation)
	f = similar(c.operand)
	set!(f, c)
	return f
	end

I couldn't see any use of concretize_condition() anywhere though...

[glwagner]

is concretize the same as regularize and materialize? We probably should use just one word for that idea...

[glwagner]

I don't think it's dangerous because as mentioned elsewhere boundary conditions are in general only meaningful in the context of prognostic time-stepping of a model...

[navidcy]

OK, I'm closing this. Thanks!