scalar getindex is disallowed with topology = (Periodic, Bounded, Bounded) using Oceananigans v0.34.1

[ali-ramadhan]

Reported by @sandreza

Must have missed this (or tests didn't cover this case) in PR #851

[glwagner]

Code is here:

Oceananigans.jl/src/Solvers/channel_pressure_solver.jl

Lines 121 to 159 in 424051c

	function solve_poisson_equation!(solver::PressureSolver{Channel, GPU}, grid)
	Nx, Ny, Nz, _ = unpack_grid(grid)
	kx², ky², kz² = solver.wavenumbers.kx², solver.wavenumbers.ky², solver.wavenumbers.kz²
	ω_4Ny⁺, ω_4Ny⁻ = solver.constants.ω_4Ny⁺, solver.constants.ω_4Ny⁻
	ω_4Nz⁺, ω_4Nz⁻ = solver.constants.ω_4Nz⁺, solver.constants.ω_4Nz⁻
	r_y_inds, r_z_inds = solver.constants.r_y_inds, solver.constants.r_z_inds
	M_ky, M_kz = solver.constants.M_ky, solver.constants.M_kz
	# We can use the same storage for the RHS and the solution ϕ.
	RHS = ϕ = solver.storage.storage1
	B = solver.storage.storage2 # Complex buffer storage.
	# Calculate DCTʸᶻ(f) in place using the FFT.
	solver.transforms.FFTyz! * RHS
	RHS⁻ = view(RHS, 1:Nx, r_y_inds, 1:Nz)
	@. B = 2 * real(ω_4Nz⁺ * (ω_4Ny⁺ * RHS + ω_4Ny⁻ * RHS⁻))
	solver.transforms.FFTx! * B # Calculate FFTˣ(f) in place.
	@. B = -B / (kx² + ky² + kz²)
	CUDA.@allowscalar B[1, 1, 1] = 0 # Setting DC component of the solution (the mean) to be zero.
	solver.transforms.IFFTx! * B # Calculate IFFTˣ(ϕ̂) in place.
	# Calculate IDCTʸᶻ(ϕ̂) in place using the FFT.
	B⁻⁺ = view(B, 1:Nx, r_y_inds, 1:Nz)
	B⁺⁻ = view(B, 1:Nx, 1:Ny, r_z_inds)
	B⁻⁻ = view(B, 1:Nx, r_y_inds, r_z_inds)
	@. ϕ = 1/4 * ω_4Ny⁻ * ω_4Nz⁻ * ((B - M_ky * M_kz * B⁻⁻) - im*(M_kz * B⁺⁻ + M_ky * B⁻⁺))
	solver.transforms.IFFTyz! * ϕ
	return nothing
	end

The issue is a call to view on line 138.

[ali-ramadhan]

Not sure why tests did not catch this in #851, but running tests on Tartarus is catching it now 🤷

Fixing and will open a PR.