Nuke broken tests #368
Merged
Nuke broken tests #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-ramadhan
added
cleanup 🧹
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
=======================================
Coverage 74.74% 74.74%
=======================================
Files 22 22
Lines 1176 1176
=======================================
Hits 879 879
Misses 297 297Continue to review full report at Codecov.
|
arcavaliere
pushed a commit
to arcavaliere/Oceananigans.jl
that referenced
this pull request
Nov 6, 2019
Nuke broken tests Former-commit-id: 78fd6de
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR nukes the last two broken tests: deep convection which has been stale and broken for months, and the example test which was never working anyways.
Now that we're back to having no broken tests, would be nice to keep it that way.