-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameters field in Model for user convenience #395
Conversation
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
+ Coverage 64.62% 71.69% +7.06%
==========================================
Files 23 23
Lines 1405 1413 +8
==========================================
+ Hits 908 1013 +105
+ Misses 497 400 -97
Continue to review full report at Codecov.
|
Performance benchmarks seem fine timing wise (model hasn't slowed down), but there seems to be some performance regression as we now perform tons of little memory allocations somewhere. I'll open an issue but this should be merged as it's not related to this PR. CPU:
GPU:
|
But only on CPU? |
Parameters field in Model for user convenience Former-commit-id: 95b12b2
This PR adds a field
parameters
toModel
. The field is intended to be utilized by users for setting parameters in user-defined forcing functions and boundary conditions functions.The forcing functions now have the function signature
whereas boundary conditions have the function signature
boundary_condition(i, j, grid, time, iteration, U, C, params)
This PR resolves #394 and #390.