Fix running of Q28 by not removing important backslashes from regex #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Q28 contains backslashes, specifically the backslash in
\1
is very important for the meaning of the query. However, both backslashes in this query are accidentally removed in almost all benchmark scripts because they usedread
instead ofread -r
.This adds the
-r
flag to all the scripts that didn't have it yet, to make sure thatread
interprets it as a raw\
character instead of an escape sequence.With this change the
REGEXP_REPLACE
call doesn't always return the literal string "1", but actually (as intended by the query) the referrer domain. This change generally makes the query significantly slower to execute, because now there are many more groups. I'm not sure how this should be listed in the results UI. It might make sense to ignore the query or something until all/most benchmarks have been rerun.This problem was found independently in #47 and #72, but fixed in a different way. I'm not sure if the fix that was made for starrocks in #72 is actually correct though, because it seems to fix the issue twice: It replaces
\1
with\\1
, but it also added the-r
flag toread
. The same is the case for thedoris
benchmark.Apart from those PRs there were already a few benchmarks that were using the
-r
flag: