Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove export of dynamic symbols #47475

Merged
merged 26 commits into from
Jul 30, 2023
Merged

Remove export of dynamic symbols #47475

merged 26 commits into from
Jul 30, 2023

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Don't expose symbols from ClickHouse binary to dynamic linker. It might fix #43933.

Note: there is a chance stack traces will become worse. But the symbol names should be able to resolve from the static symbol table if we are keeping it.

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-build Pull request with build/testing/packaging improvement label Mar 11, 2023
@alexey-milovidov
Copy link
Member Author

getResource failed, needs a fix.

@alexey-milovidov
Copy link
Member Author

It was broken by the code for Illumos.

@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented May 5, 2023

This is an automated comment for commit 2a88c24 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🔴 failure
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🔴 failure
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@robot-ch-test-poll robot-ch-test-poll added the submodule changed At least one submodule changed in this PR. label May 5, 2023
@robot-ch-test-poll robot-ch-test-poll removed the submodule changed At least one submodule changed in this PR. label May 6, 2023
@alexey-milovidov
Copy link
Member Author

It allows to save 22% of the binary size:

milovidov@milovidov-desktop:~/work/ClickHouse/build$ ls -l programs/clickhouse programs/clickhouse-no-export-dynamic
-rwxrwxr-x 1 milovidov milovidov 484630112 jul  5 02:29 programs/clickhouse
-rwxrwxr-x 1 milovidov milovidov 378422688 jul  5 02:29 programs/clickhouse-no-export-dynamic

@alexey-milovidov
Copy link
Member Author

We need to make getResource faster.

@zhanglistar
Copy link
Contributor

@alexey-milovidov Any updates here? This is a good feature gluten project also wants, we want to reduce the library size.

@alexey-milovidov
Copy link
Member Author

@zhanglistar I'm in the progress of

We need to make getResource faster.

#52228

@robot-ch-test-poll robot-ch-test-poll added the submodule changed At least one submodule changed in this PR. label Jul 23, 2023
@robot-clickhouse robot-clickhouse removed the submodule changed At least one submodule changed in this PR. label Jul 24, 2023
@alexey-milovidov alexey-milovidov self-assigned this Jul 30, 2023
@alexey-milovidov alexey-milovidov merged commit 3b481b9 into master Jul 30, 2023
132 of 145 checks passed
@alexey-milovidov alexey-milovidov deleted the no-export-dynamic branch July 30, 2023 09:21
yokofly added a commit to timeplus-io/proton that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure AD based ssh extention poisons ClickHouse with preloaded shared library
6 participants