-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove export of dynamic symbols #47475
Conversation
|
It was broken by the code for Illumos. |
This is an automated comment for commit 2a88c24 with description of existing statuses. It's updated for the latest CI running
|
481114b
to
8cd9fc4
Compare
It allows to save 22% of the binary size:
|
We need to make |
@alexey-milovidov Any updates here? This is a good feature gluten project also wants, we want to reduce the library size. |
@zhanglistar I'm in the progress of
|
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Don't expose symbols from ClickHouse binary to dynamic linker. It might fix #43933.
Note: there is a chance stack traces will become worse. But the symbol names should be able to resolve from the static symbol table if we are keeping it.