feat(time): Replace time.Time
with time.Duration
for Go type
#1097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently time and time64 types are treated as Go's
time.Time
for inserts and scan.This causes lots of complexity and bad UX for users.
Having coming up with "sane" zero values is super cumbersome. Plus it's going to be bad UX for developers if want to do some arithmetic on those types.
This PR converts that to more sane
time.Duration
type. This type fits naturally to CH time and time64 types.Also see this comment
Checklist
Delete items not relevant to your PR: