add rename_response_column option #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genzgd
approved these changes
Sep 6, 2025
| byte_source = RespBuffCls(ResponseSource(response)) # pylint: disable=not-callable | ||
| context.set_response_tz(self._check_tz_change(response.headers.get('X-ClickHouse-Timezone'))) | ||
| query_result = self._transform.parse_response(byte_source, context) | ||
| if self._column_renamer: |
There was a problem hiding this comment.
It would be nice to move this functionality into the _transform.parse_response method or the query_result object. The client doesn't need to know how to modify query_result data, and the _column_renamer seems like it belongs more to the context. The only annoyance is that the "LIMIT 0" hack is currently in the client because ClickHouse Native won't return column names :(
There was a problem hiding this comment.
Understood! Makes sense. I'll move it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a client option called
rename_response_columnthat will automatically rename columns according to one of the chosen renaming schemes. Options are:a.b.c d_ea.b.c d_ea.b.c d_ec d_ea.b.c d_ea.b.cDEa.b.c d_ecDEa.b.c d_ea.b.c_d_ea.b.c d_ec_d_eFollows closely the Java implementation from ClickHouse/clickhouse-java#923.
Closes #228
Checklist