Incorrect update count (0.3.2-patch9)

[Veirisa]

Hi!

In com.clickhouse.jdbc.internal.ClickHouseStatementImpl#updateResult:

...
// FIXME apparently this is not always true
if (currentUpdateCount <= 0L) {
    currentUpdateCount = 1L;
}
...

Yes, this isn’t always true :)

Examples:

Statement statement = connection.createStatement();
statement.execute(sql);
int updateCount = statement.getUpdateCount();

1. String sql = “CREATE TABLE new_table(x INT) engine = Memory;”
   Expected updateCount: 0
   Actual updateCount: 1

2. String sql = "INSERT INTO new_table VALUES (1), (2), (3);"
   Expected updateCount: 3
   Actual updateCount: 1

[zhicwu]

You got me :p

Have you tried send_progress_in_http_headers option like used here? With that, I think case 2 will be fixed but case 1 stays the same. Let me think how to tackle this without much parsing efforts.

Update: returning actual update count in http without additional setting is possible in 22.6+ - see ClickHouse/ClickHouse#36884

[zhicwu]

Now the update count depends on two things: 1) SQL parser(a bit outdated); and 2) summary returned from server. Above two cases work as expected on 22.6+.