Skip to content

Fix overflow error in ClickHouseLongValue.update method for BigDecimal and BigInteger #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2022
Merged

Fix overflow error in ClickHouseLongValue.update method for BigDecimal and BigInteger #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f285b73
Merge pull request #1022 from ClickHouse/develop
zhicwu Jul 29, 2022
00a2244
Fix overflow error in ClickHouseLongValue.update method for BigDecima…
Blackmorse Aug 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clickhouse-client/src/main/java/com/clickhouse/client/data/ClickHouseLongValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,12 +246,12 @@ public ClickHouseLongValue update(double value) {

@Override
public ClickHouseLongValue update(BigInteger value) {
return value == null ? resetToNullOrEmpty() : set(false, unsigned, value.longValueExact());
return value == null ? resetToNullOrEmpty() : set(false, unsigned, value.longValue());
}

@Override
public ClickHouseLongValue update(BigDecimal value) {
return value == null ? resetToNullOrEmpty() : set(false, unsigned, value.longValueExact());
return value == null ? resetToNullOrEmpty() : set(false, unsigned, value.longValue());
}

@Override
Expand Down
6 changes: 6 additions & 0 deletions clickhouse-client/src/test/java/com/clickhouse/client/data/ClickHouseLongValueTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,5 +321,11 @@ public void testUnsignedValue() throws Exception {
Assert.assertEquals(v.asBigInteger(), new BigInteger("10223372036854775101"));
Assert.assertEquals(v.asBigDecimal(), new BigDecimal("10223372036854775101"));
Assert.assertEquals(v.asString(), "10223372036854775101");

v.update(new BigDecimal("10223372036854775101"));
Assert.assertEquals(v.asLong(), -8223372036854776515L);
Assert.assertEquals(v.asBigInteger(), new BigInteger("10223372036854775101"));
Assert.assertEquals(v.asBigDecimal(), new BigDecimal("10223372036854775101"));
Assert.assertEquals(v.asString(), "10223372036854775101");
}
}