Send null when nullable #2149
Merged
Send null when nullable #2149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@Paultagoras would you please add a test for JDBC to check that we are getting null? I remember it has separate class or so. |
mzitnik
approved these changes
Feb 15, 2025
|
|
||
| private static void serializePrimitiveData(OutputStream stream, Object value, ClickHouseColumn column) throws IOException { | ||
| //Handle null values | ||
| if (value == null && column.isNullable()) {//Only nullable columns can have null values |
There was a problem hiding this comment.
If it null and not nullable should we throw an exception like data is not valid
There was a problem hiding this comment.
I considered doing that, but apparently there's logic for some of the data types that would then fail (like the new dynamic stuff) 🫠
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2122
Checklist
Delete items not relevant to your PR: