Skip to content

Bugfix for Boolean type formatting #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Bugfix for Boolean type formatting #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f655cb1
Bugfix for Boolean type formatting: needsQuoting(Boolean) -> false
Dec 10, 2019
cd6da5a
Added unit tests for ClickHousePreparedStatementParameter.fromObject
Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/ru/yandex/clickhouse/util/ClickHouseValueFormatter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,9 @@ public static boolean needsQuoting(Object o) {
if (o instanceof Number) {
return false;
}
if (o instanceof Boolean) {
return false;
}
if (o.getClass().isArray()) {
return false;
}
Expand Down
21 changes: 21 additions & 0 deletions src/test/java/ru/yandex/clickhouse/ClickHousePreparedStatementParameterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,25 @@ public void testArrayAndCollectionParam() {
assertEquals(p0.getBatchValue(), p1.getBatchValue());
}

@Test
public void testBooleanParam() {
assertEquals(ClickHousePreparedStatementParameter.fromObject(Boolean.TRUE,
TimeZone.getDefault(), TimeZone.getDefault()).getRegularValue(), "1");
assertEquals(ClickHousePreparedStatementParameter.fromObject(Boolean.FALSE,
TimeZone.getDefault(), TimeZone.getDefault()).getRegularValue(), "0");
}

@Test
public void testNumberParam() {
assertEquals(ClickHousePreparedStatementParameter.fromObject(10,
TimeZone.getDefault(), TimeZone.getDefault()).getRegularValue(), "10");
assertEquals(ClickHousePreparedStatementParameter.fromObject(10.5,
TimeZone.getDefault(), TimeZone.getDefault()).getRegularValue(), "10.5");
}

@Test
public void testStringParam() {
assertEquals(ClickHousePreparedStatementParameter.fromObject("someString",
TimeZone.getDefault(), TimeZone.getDefault()).getRegularValue(), "'someString'");
}
}