Skip to content

Batch get archive #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 9, 2017
Merged

Batch get archive #198

merged 8 commits into from
Mar 9, 2017

Conversation

delgadom
Copy link
Member

@delgadom delgadom commented Mar 9, 2017 •
edited
Loading

  • closes Batch get_archive #191
  • tests added / passed
  • passes git diff upstream/master | flake8 --diff
  • whatsnew entry

Get multiple archives from a list of archive_names. Involves a single manager query.

@delgadom delgadom requested a review from jgerardsimcock March 9, 2017 04:47
@coveralls
Copy link

coveralls commented Mar 9, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 96.205% when pulling a4cfcf9 on batch_get_archive into 5951cb8 on staging.

@delgadom
Copy link
Member Author

delgadom commented Mar 9, 2017

Coverage decreases because our test datasets are not large enough to trigger paged batch_get_item queries. I think the code will work if we ever get there but it's currently untested.

@coveralls
Copy link

coveralls commented Mar 9, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 96.245% when pulling 91732b7 on batch_get_archive into ce8b055 on staging.

@delgadom delgadom merged commit 14be0bd into staging Mar 9, 2017
@delgadom delgadom deleted the batch_get_archive branch March 9, 2017 10:12
@delgadom delgadom mentioned this pull request Mar 9, 2017
Merged
5 tasks
@delgadom delgadom self-assigned this Mar 9, 2017
@coveralls
Copy link

coveralls commented Mar 9, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 96.245% when pulling d6f4d49 on batch_get_archive into ce8b055 on staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgerardsimcock jgerardsimcock Awaiting requested review from jgerardsimcock

Assignees

@delgadom delgadom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delgadom @coveralls