Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Windows fast launch #521

Merged
merged 3 commits into from
Mar 27, 2024
Merged

feat: Windows fast launch #521

merged 3 commits into from
Mar 27, 2024

Conversation

kichik
Copy link
Member

@kichik kichik commented Mar 9, 2024

Add an option for enabling fast launch for Windows AMIs. This should speed up booting up of EC2 Windows runners.

Note that it does come with extra cost.

const ec2WindowsImageBuilder = Ec2RunnerProvider.imageBuilder(stack, 'Windows EC2 Builder', {
  os: Os.WINDOWS,
  vpc,
  awsImageBuilderOptions: {
    fastLaunchOptions: {
      enabled: true,
    },
  },
});
const runners = new GitHubRunners(stack, 'runners', {
  providers: [
    new Ec2RunnerProvider(stack, 'Fast Windows', {
      labels: ['windows'],
      imageBuilder: ec2WindowsImageBuilder,
    }),
  ],
}

Before:
image

After:
image

Resolves #466
Closes #514

Update snapshot. See details in [workflow run].

[Workflow Run]: https://github.com/CloudSnorkel/cdk-github-runners/actions/runs/8217636135

------

*Automatically created by projen via the "upgrade-snapshot" workflow*
@pharindoko
Copy link
Contributor

pharindoko commented Mar 13, 2024

Tried it out: Works super easy and great.
Only thing I have found - 5 subnets are listed in the stepfunctions while I only provided 2.

image

@kichik
Copy link
Member Author

kichik commented Mar 14, 2024

Thanks! Not sure how the subnets can change as nothing was modified on the provider side. Would you mind sharing the code that limits to two subnets?

@pharindoko
Copy link
Contributor

will check this next week and try it out in another account as well.

@pharindoko
Copy link
Contributor

@kichik As promised I tried it out in another account with non-default vpc and it works as well in a super nice way. Havent seen any issues yet :) - so heres my approval :D

@kichik
Copy link
Member Author

kichik commented Mar 27, 2024

Thanks @pharindoko!

@mergify mergify bot merged commit 319b011 into main Mar 27, 2024
12 checks passed
@mergify mergify bot deleted the win-fast-launch branch March 27, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: windows runner - enable fast launch option
3 participants