Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Group) Logic to mute and unmute the notification on mobile level #362

Closed
sumairasaeed opened this issue Oct 14, 2016 · 13 comments
Closed

Comments

@sumairasaeed
Copy link
Contributor

On the client side, the group member should have option to mute or unmute the group notifications. This is in whatsapp and saves us from too much notifications and alerts when lots of people are speaking in a group at once. User can turn it on or off.

@sumairasaeed sumairasaeed added this to the Group Messaging Feature milestone Oct 14, 2016
@sumairasaeed sumairasaeed changed the title (Group) Logic to mute and unmute the notification on mobile level #236 (Group) Logic to mute and unmute the notification on mobile level Oct 14, 2016
@sumairasaeed
Copy link
Contributor Author

I explored and read up on it yesterday. I found that in order to mute/unmute notifications, some changes will be required in server payload also. I have opened task for this on server side Cloudkibo/CloudKibo#472 .

@sumairasaeed
Copy link
Contributor Author

I have completed the client side code for this. Also designed the UI for setting "mute" for a specific group. I will need to add small code to notify server after server side task Cloudkibo/CloudKibo#472 is done.

@sumairasaeed
Copy link
Contributor Author

This is blocked due to server side task Cloudkibo/CloudKibo#472

@jekram
Copy link
Contributor

jekram commented Dec 26, 2016

why do we need server side code to this functionality?

@sumairasaeed
Copy link
Contributor Author

sumairasaeed commented Dec 26, 2016 via email

@jekram
Copy link
Contributor

jekram commented Dec 26, 2016

I understand that server is sending the notification. I am asking why client cannot ignore the notification based on local settings?

@sumairasaeed
Copy link
Contributor Author

sumairasaeed commented Dec 26, 2016 via email

@jekram
Copy link
Contributor

jekram commented Dec 26, 2016

Only work on this based on the overall priority

@jekram jekram added the Blocked label Dec 26, 2016
@jekram jekram removed the Blocked label May 9, 2017
@jekram
Copy link
Contributor

jekram commented May 9, 2017

I have removed the "blocked". However, I do not understand why we need work on the server side. This is a client side work and tell me why we cannot make that chat or group to be quite?

@sumairasaeed
Copy link
Contributor Author

Sir, on iOS alert , sound fields are displayed by mobile by reading payload from server. We can change overall setting of app by not registering app to play 'sound' . But we have no control to mute certain notifications. It depends on payload received from server. If server has sent 'sound' field in payload then it will play else it would be silent

@sumairasaeed
Copy link
Contributor Author

Worked on this yesterday. Coded the logic to Mute group notifications. I found from logs that on server, group is marked as mute but even then payload field contains 'alert' and 'sound' field so group notification is not being mute. The server endpoint returns success but is not working correctly.
Here are the logs screenshot:
screen shot 2017-05-23 at 10 16 46 am
I will again test this endpoint Cloudkibo/CloudKibo#472 with @sojharo

@sumairasaeed
Copy link
Contributor Author

sumairasaeed commented May 23, 2017

This task has been completed now. Mute and unmute group feature is working fine.

@jekram
Copy link
Contributor

jekram commented May 24, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants