-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avatars are shown blank #488
Comments
for UI issues it is better to attach a screenshot |
I see Avatar is missing. I do not understand when you say images are missing? |
I meant same that images of avatars are not loaded. |
Then this is a bug but not high priority. |
Worked and debugged on this. Was stuck on retrieving avatars by converting asset resource to format required by library. Looking more into this |
I do not understand this. I am assuming this was working before and it is a conversion issue. WE should not try to enhance the logic.We should get it working and then change later. |
Should we not assume that different library would have Thier own unique parameters? However did we tested using the new library? |
what is the update here? |
I want update on Github to be updated when the task is assigned and you are working on it. Explain it here |
Using Kingfisher library, was able to show default avatars. The issue is in converting real avatars fetched from Contacts book to a format acceptable by library. Searched more and found that a submodule of Alamofire library called 'AlamofireImage' accepts the format we have and it can fulfil the purpose and solve our issue. Trying to integrate AlamofireImage into our app. It is having some conflicts. This is in progress. |
what formats Kingfisher accepts and what format we have when we fetch from Contact book? same question for Alamofireimage? |
Kingfisher accepts url and we have Data format when we fetch from Contact book. AlamofireImage accepts both url and data format. I worked more today and and now successfully integrated AlamofireImage into our app. Now working to make required changes to show avatars. |
This task has been completed now. Avatars are shown correctly. |
Thanks |
Avatars are shown blank and images not loaded. Looking into it.
The text was updated successfully, but these errors were encountered: