Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatars are shown blank #488

Closed
sumairasaeed opened this issue Feb 13, 2017 · 16 comments
Closed

Avatars are shown blank #488

sumairasaeed opened this issue Feb 13, 2017 · 16 comments

Comments

@sumairasaeed
Copy link
Contributor

Avatars are shown blank and images not loaded. Looking into it.

@jekram
Copy link
Contributor

jekram commented Feb 13, 2017

for UI issues it is better to attach a screenshot

@sumairasaeed
Copy link
Contributor Author

Here is screenshot:
screen shot 2017-02-13 at 10 42 38 am

@jekram
Copy link
Contributor

jekram commented Feb 13, 2017

I see Avatar is missing. I do not understand when you say images are missing?

@sumairasaeed
Copy link
Contributor Author

I meant same that images of avatars are not loaded.

@jekram
Copy link
Contributor

jekram commented Feb 13, 2017

Then this is a bug but not high priority.

@sumairasaeed
Copy link
Contributor Author

Worked and debugged on this. Was stuck on retrieving avatars by converting asset resource to format required by library. Looking more into this

@jekram
Copy link
Contributor

jekram commented Feb 17, 2017

I do not understand this. I am assuming this was working before and it is a conversion issue. WE should not try to enhance the logic.We should get it working and then change later.

@sumairasaeed
Copy link
Contributor Author

We replaced Haneke image caching library with Kingfisher. The issue is that it requires different format of parameters which were required by Haneke library. Worked on this. I was able to cache and retrieve default avatar images from cache when avatar is not available. Here is screenshot:
screen shot 2017-02-17 at 6 00 44 pm

Remaining work on this is to retrieve avatars available and show.

@jekram
Copy link
Contributor

jekram commented Feb 17, 2017

Should we not assume that different library would have Thier own unique parameters? However did we tested using the new library?

@jekram
Copy link
Contributor

jekram commented Feb 20, 2017

what is the update here?

@jekram
Copy link
Contributor

jekram commented Feb 20, 2017

I want update on Github to be updated when the task is assigned and you are working on it.

Explain it here

@sumairasaeed
Copy link
Contributor Author

Using Kingfisher library, was able to show default avatars. The issue is in converting real avatars fetched from Contacts book to a format acceptable by library. Searched more and found that a submodule of Alamofire library called 'AlamofireImage' accepts the format we have and it can fulfil the purpose and solve our issue. Trying to integrate AlamofireImage into our app. It is having some conflicts. This is in progress.

@jekram
Copy link
Contributor

jekram commented Feb 20, 2017

what formats Kingfisher accepts and what format we have when we fetch from Contact book?

same question for Alamofireimage?

@sumairasaeed
Copy link
Contributor Author

Kingfisher accepts url and we have Data format when we fetch from Contact book. AlamofireImage accepts both url and data format. I worked more today and and now successfully integrated AlamofireImage into our app. Now working to make required changes to show avatars.

@sumairasaeed
Copy link
Contributor Author

This task has been completed now. Avatars are shown correctly.

@jekram
Copy link
Contributor

jekram commented Feb 22, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants