(Error) App crashing soon after launch

[sumairasaeed]

App crashing after showing blank page for a second. Looking into logs

[jekram]

What is the out come of this analysis?

[jekram]

Is this issue related to Kingfisher Image library? Is this happening on your local machine? Where are the logs? Have we checked how are we calling this library? Do we need this library or can it be bypassed for now?

[sumairasaeed]

Yes this is related to Kingfisher Image library happening on local machine. Have not pushed to test flight as it was crashing. Let me know if i need to. Was planning to push once app is in running state. Yes looked into library documentation. We need this library for showing avatars.

…

On Fri, Feb 10, 2017 at 7:49 PM, Cloudkibo ***@***.***> wrote: Is this issue related to Kingfisher Image library? Is this happening on your local machine? Where are the logs? Have we checked how are we calling this library? Do we need this library or can it be bypassed for now? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#486 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKbhpxMvbLqR_jIaESh8d-PYLsaNgx7sks5rbHjtgaJpZM4L9UX2> .

[jekram]

Sumaira we do not have all year to fix bugs. When something crash we know exactly what caused it. In that case we should fix it right away. If you cannot determine it right away then we can bypass that feature and fix it later. If this case Avatar not to work. Then we should bypass this. You have to use your judgement on how long it will take to fix it and critical that function is? You should be able to use your judgement. We will lots of bugs so we need to fix these quickly.

[sumairasaeed]

Crash issue is fixed. App not crashing on launch. But images are not loaded and it shows blank area in place of image. Looking into it. I will fix this image loading bug as part of this issue

[sumairasaeed]

Opened seperate issue for black avatars #488 . App crash on launch was fixed. we can close this now.

[jekram]

Document what was the issue. "Crash issue is fixed", is not sufficient.

[sumairasaeed]

Parameters passed to Kingfisher library function was incorrect so was not parsed correctly. This was causing the crash.

…

On Mon, Feb 13, 2017 at 11:53 AM, Cloudkibo ***@***.***> wrote: Document what was the issue. "Crash issue is fixed", is not sufficient. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#486 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKbhp1Xk-i8GcsVi__3oAER2IA-hJSFoks5rb_36gaJpZM4L9UX2> .