Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 2.0 #617

Merged
merged 47 commits into from
Oct 12, 2015
Merged

Swift 2.0 #617

merged 47 commits into from
Oct 12, 2015

Conversation

bpoplauschi
Copy link
Member

Merging the swift_2.0 branch into master before creating a Beta release

Tristan Seifert and others added 30 commits June 17, 2015 11:10
Fixed compile errors in Xcode 7 with Swift 2.0
It looks like Xcode 7 now supports textual headers.
# Xcode7-beta3
 * Error when using current head of swift_2.0 branch
 * "Cannot import module that is being compiled" ... which actually makes sense compared to most swift xcode errors
 * Simply remove the import line
Fix Xcode 7 beta3 "Cannot import module that is being compiled" error
…s CocoaLumberjack(Swift)-watchOS, Creates watchOSSwiftTest
Add watchOSSwiftTest and some changes on Lumberjack.xcodeproj
Using Xcode 7 image on Travis CI for testing Swift 2.0
tvOS does not support `host_info()` anymore. At the same time it supports `[[NSProcessInfo processInfo] activeProcessorCount]` so this can be used instead.
matthiaswenz and others added 17 commits October 3, 2015 15:21
Mac OS before 10.5 would not support [NSProcessInfo processorCount] so make this safe.
Add tvOS targets on project
Conflicts:
- .travis.yml
  Resolved by choosing the version from the swift_2.0 branch that requires the
  xcode7 build environment.

- Classes/DDFileLogger.h
  Resolved by choosing the changes from 58ae948 by sinoru over changes from
  b765caf by stephencelis.
  See discussion on issue #592

- Lumberjack.xcodeproj/project.pbxproj
  Resolved by choosing the version from the swift_2.0 branch and manually
  redoing what was done in 9f41918.

  Since it was branched off master, there have been three new commits modifying
  the project file:

  - f1cd4b8 Make CocoaLumberjackSwift-iOS Target depend on CocoaLumberjack-iOS

    Similar change was done when re-adding CocoaLumberjackSwift-iOS
    target again (after it had been removed) in fa57e49

  - 9f41918 Mark CocoaLumberjack dynamic libraries as Require Only App-Extension-Safe API

    Manually applied changes again in GUI after choosing project file from
    swift_2.0 branch. Switched the 'Require Only App-Extension-Safe API' to
    'Yes' on CocoaLumberjack, CocoaLumberjackSwift, CocoaLumberjack-iOS and
    CocoaLumberjackSwift-iOS targets.
    CocoaLumberjack(Swift)-watchOS targets already had this option set.

  - 96b1dfd Silence the Xcode 7 upgrade check.

    Similar change was done in aee0707
There was a comment, in line 55 indicating that the block would be called twice
for every log. Appearantly this isn't the case anymore.

Note: I do not fully understand what is going on there and why the behavior
seems to have changed.
I only observed the current behavior to be that the block is called exactly
once for every log.

@bpoplauschi please double check this commit
Merge master back into swift_2.0
Conflicts:
	Classes/CocoaLumberjack.swift
	Classes/DDLog.m
@bpoplauschi bpoplauschi added this to the 2.1.0 - Swift milestone Oct 12, 2015
bpoplauschi added a commit that referenced this pull request Oct 12, 2015
@bpoplauschi bpoplauschi merged commit 1b5711d into master Oct 12, 2015
@rivera-ernesto
Copy link
Member

Well seems like the 2.0.2 release was made before this, so we may not need a separate branch for Xcode 6.x support (yet).

@rivera-ernesto rivera-ernesto deleted the swift_2.0 branch October 21, 2015 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants