Skip to content
This repository has been archived by the owner on Nov 3, 2020. It is now read-only.

Show Project info #141

Merged
merged 25 commits into from
Jan 15, 2016
Merged

Show Project info #141

merged 25 commits into from
Jan 15, 2016

Conversation

orta
Copy link
Member

@orta orta commented Dec 6, 2015

Initial stab at real design, it's cells in a tableview, so they can repeat themselves, and the grey text would not show in the app, only in IB

screen shot 2015-12-06 at 5 15 58 pm

I also started looking including mini version of the snapshots testing metaphor, it's pretty rough ATM, but should work.

@orta orta changed the title Show Project info [WIP] Show Project info Dec 11, 2015
@orta
Copy link
Member Author

orta commented Dec 21, 2015

Gonna try unblock myself here by using:

p = Podfile.from_file("Podfile")
return YAML::load(p.to_yaml).to_json

@segiddins
Copy link
Member

@orta

podfile.to_hash.to_json

@orta
Copy link
Member Author

orta commented Dec 24, 2015

Got it working with dummy data

screen shot 2015-12-24 at 18 44 28

@orta
Copy link
Member Author

orta commented Dec 24, 2015

@alloy This is one of the ones I'm blocked on ( based on #77 ) I can still do some more work on the bindings stuff, but getting Xcode / Podfile info is tough.

@orta
Copy link
Member Author

orta commented Dec 28, 2015

Polished it a bit and added some more dummy data
screen shot 2015-12-28 at 16 32 41

@alloy
Copy link
Member

alloy commented Dec 31, 2015

The “Warnings” part doesn’t make much sense in the global project overview, as inhibit_all_warnings! is an inheritable option per target: https://guides.cocoapods.org/syntax/podfile.html#inhibit_all_warnings_bang

@orta
Copy link
Member Author

orta commented Jan 1, 2016

great, I can move that 👍

@orta
Copy link
Member Author

orta commented Jan 3, 2016

Started to get somewhere!

screen shot 2016-01-03 at 12 48 48

@orta
Copy link
Member Author

orta commented Jan 3, 2016

Hrm, pulling some of this off looks like being able to apply ENV vars to plist metadata, for example its common to have plists like:

screen shot 2016-01-03 at 12 56 57

Where we then have to apply these ENV vars:

screen shot 2016-01-03 at 12 57 19

Getting the scheme might be complex? xcodebuild -workspace app/CocoaPods.xcworkspace -scheme CocoaPods -showBuildSettings - it may require doing: xcodebuild -workspace app/CocoaPods.xcworkspace -list. I worry about the brittle-ness of this. We all know how fun Xcode updates can be.

@orta orta assigned orta and unassigned alloy Jan 3, 2016
tableView.reloadData()
}

// TODO: I bet someone could code-golf this pretty well
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this could be hugely simplified using map/reduce:

targets.filter { $0.name != targetName }.map { $0.pods }

etc


class CocoaPodsTests: QuickSpec {
class CocoaPodsTests: NSObject {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this empty class really necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

@orta
Copy link
Member Author

orta commented Jan 13, 2016

I think the fix around the ENV var stuff is to make my own images for different bundle types

@orta
Copy link
Member Author

orta commented Jan 13, 2016

screen shot 2016-01-13 at 11 26 49

@orta
Copy link
Member Author

orta commented Jan 13, 2016

screen shot 2016-01-13 at 11 27 51

@orta orta changed the title [WIP] Show Project info Show Project info Jan 14, 2016
@orta
Copy link
Member Author

orta commented Jan 14, 2016

Alright, I'm good for this now.

Support a versioned build environment
- (void)addBlock:(void (^)(void))block
{
void (^ourBlock)(void) = [block copy];
self.completionBlocks = self.completionBlocks ?: [NSMutableArray array];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also just 'id' the block.

orta added a commit that referenced this pull request Jan 15, 2016
@orta orta merged commit 11b9253 into master Jan 15, 2016
@alloy alloy deleted the project_info branch January 18, 2016 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants