Hash scope suffixes if they are over 50 characters

[endocrimes]

supersedes CocoaPods/Core#344
actually closes #5491

[segiddins]

👍🏻

[mrackwitz]

I don't think we should hash the full label. Just hashing the scope suffix should be sufficient. I can push a PR for that later today.

[endocrimes]

@mrackwitz I can update this PR pretty easily. TBH tho, I don't think we'd really get much of an advantage by doing that?

[endocrimes]

@mrackwitz Updated

[segiddins]

this second line should be here

[endocrimes]

Oops, happened during the rebase, fixing now.

[endocrimes]

Build is failing because json is refusing to build on system ruby, but tests are passing elsewhere.
I'm too tired to look into that now, but will take a look in the morning.

[mrackwitz]

Thanks for updating the PR, @dantoml. 😀
I took a stab at that previously as well, but still didn't came around writing proper specs for it. My idea was to limit the length of the suffix already from the analyzer at the point of the target generation. That's what I came up with:

diff --git a/lib/cocoapods/installer/analyzer/pod_variant_set.rb b/lib/cocoapods/installer/analyzer/pod_variant_set.rb
index b758c31..fd7dc3a 100644
--- a/lib/cocoapods/installer/analyzer/pod_variant_set.rb
+++ b/lib/cocoapods/installer/analyzer/pod_variant_set.rb
@@ -23,7 +23,10 @@ module Pod
         #
         def scope_suffixes
           return { variants.first => nil } if variants.count == 1
-          scope_by_specs
+          Hash[scope_by_specs.map do |variant, scope|
+            scope = Digest::MD5.hexdigest(scope)[0..7] if scope.length > 100
+            [variant, scope]
+          end]
         end

         # Groups the collection by result of the block.

You might want to take over at least the cropping of the hash to 8 chars?

[endocrimes]

@mrackwitz Updated

[segiddins]

👍

[YoniTsafir]

@dantoml question about this (sorry if commenting on a closed PR isn't the place but I'm not sure where else to ask): if I want during post_install what target name from the pod's project represents which original PodTarget name, do I have any way of doing so?