Skip to content

Conversation

not-matthias
Copy link
Member

@not-matthias not-matthias commented Sep 12, 2025

Used a slightly different logic than in the runner, but verified with other repos using a similar approach:

GITHUB_HEAD_REF is only set for the PR, we can fallback to GITHUB_REF_NAME in any other case.

Copy link

codspeed-hq bot commented Sep 12, 2025

CodSpeed Performance Report

Merging #15 will degrade performances by 16.4%

Comparing cod-1321-fix-incorrect-version-selection-in-codspeed-go (c396b8e) with main (33bf04e)1

Summary

❌ 2 regressions
✅ 16 untouched
🆕 4 new

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 BenchmarkQuicktest N/A 179.3 µs N/A
🆕 BenchmarkWithSlogAssert N/A 260.8 µs N/A
🆕 BenchmarkTestifyWithNew N/A 113 µs N/A
🆕 BenchmarkTestifyWithT N/A 85.1 µs N/A
BenchmarkFibonacci20_Loop 110.4 µs 132 µs -16.4%
BenchmarkSleep1us_Loop 1.8 µs 2 µs -10.43%

Footnotes

  1. No successful run was found on main (ed306a6) during the generation of this report, so 33bf04e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@not-matthias not-matthias requested a review from art049 September 12, 2025 11:55
@not-matthias not-matthias force-pushed the cod-1321-fix-incorrect-version-selection-in-codspeed-go branch from 4165d62 to 6a6f81a Compare September 12, 2025 14:19
@not-matthias not-matthias force-pushed the cod-1321-fix-incorrect-version-selection-in-codspeed-go branch from 6a6f81a to c396b8e Compare September 12, 2025 14:29
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@not-matthias not-matthias merged commit c396b8e into main Sep 12, 2025
9 of 10 checks passed
@not-matthias not-matthias deleted the cod-1321-fix-incorrect-version-selection-in-codspeed-go branch September 12, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants