-
Notifications
You must be signed in to change notification settings - Fork 0
feat: golang dx improvements #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #16 will improve performances by ×26Comparing Summary
Benchmarks breakdown
|
95d207c
to
101aac0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces multiple improvements to the Go benchmarking system including better iteration tracking, improved output ordering, enhanced logging configuration, and adds support for helper functions in benchmarks.
Key changes:
- Enhanced iteration counting logic for both b.N and b.Loop() patterns
- Moved benchmark output formatting before CodSpeed processing for better UX
- Improved import patching to cover all Go files instead of just benchmark files
- Added support for benchmark helper functions with a new test project
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
testing/testing/benchmark.go | Enhanced iteration tracking logic and reordered output formatting |
go-runner/testdata/projects/example-with-helper/* | New test project demonstrating benchmark helper function support |
go-runner/src/results/raw_result.rs | Removed default empty iters_per_round fallback logic |
go-runner/src/main.rs | Enhanced logging configuration with default info level |
go-runner/src/integration_tests.rs | Added test case for example-with-helper project |
go-runner/src/builder/templater.rs | Updated to patch all files instead of specific benchmark files |
go-runner/src/builder/patcher.rs | Expanded import patching to cover all Go files |
Various snapshot files | Updated test snapshots reflecting changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
47a8cd0
to
9cfcfe1
Compare
9cfcfe1
to
9d21400
Compare
9d21400
to
81d403b
Compare
Note:
b.Loop()
benchmarks previously reported an incorrect time because rounds was always set to 1. This is why we have a huge performance boost.