-
Notifications
You must be signed in to change notification settings - Fork 16
feat: add perf v2 support #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d43c27
to
8a1f89e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates CodSpeed's Rust integration from a FIFO-based communication system to a new C-based instrument hooks API for performance v2 support. The changes enable better benchmark instrumentation and timing measurement for performance analysis.
- Replaces FIFO communication with instrument hooks FFI bindings
- Adds support for benchmark timestamp collection and marker insertion
- Updates benchmark examples to use the new
codspeed_divan_compat
API
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
crates/divan_compat/divan_fork/src/divan.rs | Updates benchmark URI reporting to use instrument hooks instead of FIFO |
crates/divan_compat/divan_fork/src/bench/mod.rs | Replaces FIFO guards with instrument hooks and adds timestamp collection |
crates/codspeed/src/instrument_hooks/mod.rs | New FFI wrapper for C instrument hooks library with Unix/non-Unix implementations |
crates/codspeed/src/instrument_hooks/ffi.rs | FFI bindings generated from C headers |
crates/codspeed/build.rs | Build script to compile C library and generate bindings |
crates/codspeed/Cargo.toml | Adds build dependencies for bindgen and cc |
.gitmodules | Adds instrument-hooks submodule |
.github/workflows/ci.yml | Updates CI configuration for new instrumentation mode |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
8a1f89e
to
4279028
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
4adacd6
to
440c59f
Compare
CodSpeed Instrumentation Performance ReportMerging #121 will degrade performances by 23.49%Comparing Summary
Benchmarks breakdown
|
db66db2
to
9391337
Compare
9391337
to
088d32d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
5bd327f
to
6458923
Compare
4a691ee
to
c9b70bf
Compare
CodSpeed WallTime Performance ReportMerging #121 will degrade performances by 62.57%Comparing Summary
Benchmarks breakdown
|
No description provided.