-
Notifications
You must be signed in to change notification settings - Fork 16
feat!(cargo-codspeed): Allow filtering by benchmark name #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!(cargo-codspeed): Allow filtering by benchmark name #122
Conversation
a95403c
to
adb6854
Compare
CodSpeed Instrumentation Performance ReportMerging #122 will degrade performances by 6.78%Comparing Summary
Benchmarks breakdown
|
CodSpeed WallTime Performance ReportMerging #122 will degrade performances by 20.91%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall! @not-matthias I let you do the final review
…dspeed run` There previously was a confusion between benchmark name, aka the name the user gives to individual benchmarks, and benchmark targets. Now, benchmark target filtering is only done through `--workspace`, `--package` and `--exclude` cli flags for both `cargo codspeed build` and `cargo codspeed run`. In addition, `cargo codspeed run` now properly forwards the `benchname` positional argument to the benchmark target, in order to filter benchmarks ran. This is a breaking change, but it makes `cargo-codspeed` more in line with `cargo bench`
adb6854
to
43a2ff0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
CodSpeedHQ/codspeed-rust#122 が入ったcargo-codspeed v4がリリースされてCI が落ちたので、v4の方式に適応する。
This PR removes the confusion there was before between benchmark names and benchmark targets
Now, benchmark target filtering is only done through
--workspace
,--package
and--exclude
cli flags for bothcargo codspeed build
andcargo codspeed run
.In addition,
cargo codspeed run
now properly forwards the bench_name positionnal argument to the benchmark target, in order to filter benchmarks ran. This is a breaking change, but it makescargo-codspeed
more in line withcargo bench
The second commit restores the option to filter benchmark target but now follows the
cargo build
API using the--bench
target that can be repeated