Skip to content

Conversation

not-matthias
Copy link
Member

@not-matthias not-matthias commented Oct 3, 2025

Fixes #130

Copy link

codspeed-hq bot commented Oct 3, 2025

CodSpeed Instrumentation Performance Report

Merging #131 will improve performances by 13.82%

Comparing cod-1442-codspeed-divan-compat-macos-linking-failure-on-v4 (9ace864) with main (22e8366)

Summary

⚡ 5 improvements
✅ 181 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
fib_10 859.7 ns 830.6 ns +3.51%
recursive[0] 240.3 ns 211.1 ns +13.82%
recursive[5] 320.3 ns 291.1 ns +10.02%
instant 363.6 ns 334.4 ns +8.72%
system_time 363.6 ns 334.4 ns +8.72%

Copy link

codspeed-hq bot commented Oct 3, 2025

CodSpeed WallTime Performance Report

Merging #131 will degrade performances by 86.11%

Comparing cod-1442-codspeed-divan-compat-macos-linking-failure-on-v4 (9ace864) with main (22e8366)

Summary

⚡ 20 improvements
❌ 23 regressions
✅ 125 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
build_vec 180 ns 215 ns -16.28%
Recursive 46.1 µs 50.6 µs -8.97%
Recursive[20] 45.9 µs 50.6 µs -9.39%
Recursive[21] 75 µs 82.2 µs -8.76%
large_drop 183.4 µs 802.7 µs -77.15%
large_setup 14 ns 20 ns -30%
small_setup 1 ns 2 ns -50%
iter_with_setup 48 ns 36 ns +33.33%
iter_batched_large_input 7 ns 44 ns -84.09%
iter_batched_per_iteration 48 ns 36 ns +33.33%
iter_batched_ref_large_input 5 ns 36 ns -86.11%
iter_batched_ref_per_iteration 44 ns 36 ns +22.22%
iter_with_setup 46 ns 36 ns +27.78%
from_elem[16384] 1,047 ns 994 ns +5.33%
from_elem[4096] 354 ns 338 ns +4.73%
from_elem[8192] 579 ns 506 ns +14.43%
recursive_memoized[BTreeMap<u64, u64>, 10] 579 ns 602 ns -3.82%
recursive_memoized[BTreeMap<u64, u64>, 20] 2 µs 2.3 µs -14%
generate_combinations[5] 944 ns 1,139 ns -17.12%
generate_combinations[6] 2 µs 1.9 µs +4.46%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@not-matthias not-matthias force-pushed the cod-1442-codspeed-divan-compat-macos-linking-failure-on-v4 branch from 4ac9e86 to ced6205 Compare October 3, 2025 14:13
@not-matthias not-matthias marked this pull request as ready for review October 3, 2025 14:13
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the build system to properly support macOS by restricting the instrument-hooks functionality to Linux only and updating the CI configuration to test across multiple platforms.

  • Replaced #[cfg(unix)] with #[cfg(target_os = "linux")] to specifically target Linux instead of all Unix-like systems
  • Added early return in build script for non-Linux platforms to skip compilation of instrument-hooks C library
  • Consolidated CI lint jobs into a matrix strategy that tests on Ubuntu, Windows, and macOS

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
crates/codspeed/src/instrument_hooks/mod.rs Changed conditional compilation from Unix to Linux-specific targeting
crates/codspeed/instrument-hooks Updated submodule commit reference
crates/codspeed/build.rs Added early return for non-Linux platforms to skip C library compilation
.github/workflows/ci.yml Consolidated separate lint jobs into matrix strategy for cross-platform testing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@not-matthias not-matthias force-pushed the cod-1442-codspeed-divan-compat-macos-linking-failure-on-v4 branch from ced6205 to 48e338b Compare October 3, 2025 14:23
@not-matthias not-matthias force-pushed the cod-1442-codspeed-divan-compat-macos-linking-failure-on-v4 branch from b915aea to b95dc4e Compare October 3, 2025 14:49
@not-matthias not-matthias requested a review from Copilot October 3, 2025 15:04
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@not-matthias not-matthias merged commit 9ace864 into main Oct 3, 2025
33 of 35 checks passed
@not-matthias not-matthias deleted the cod-1442-codspeed-divan-compat-macos-linking-failure-on-v4 branch October 3, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codspeed-divan-compat macos linking failure on v4
2 participants