-
Notifications
You must be signed in to change notification settings - Fork 16
fix: build on macos #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: build on macos #131
Conversation
CodSpeed Instrumentation Performance ReportMerging #131 will improve performances by 13.82%Comparing Summary
Benchmarks breakdown
|
CodSpeed WallTime Performance ReportMerging #131 will degrade performances by 86.11%Comparing Summary
Benchmarks breakdown
|
4ac9e86
to
ced6205
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the build system to properly support macOS by restricting the instrument-hooks functionality to Linux only and updating the CI configuration to test across multiple platforms.
- Replaced
#[cfg(unix)]
with#[cfg(target_os = "linux")]
to specifically target Linux instead of all Unix-like systems - Added early return in build script for non-Linux platforms to skip compilation of instrument-hooks C library
- Consolidated CI lint jobs into a matrix strategy that tests on Ubuntu, Windows, and macOS
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
crates/codspeed/src/instrument_hooks/mod.rs | Changed conditional compilation from Unix to Linux-specific targeting |
crates/codspeed/instrument-hooks | Updated submodule commit reference |
crates/codspeed/build.rs | Added early return for non-Linux platforms to skip C library compilation |
.github/workflows/ci.yml | Consolidated separate lint jobs into matrix strategy for cross-platform testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ced6205
to
48e338b
Compare
b915aea
to
b95dc4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Fixes #130