Skip to content

Conversation

not-matthias
Copy link
Member

@not-matthias not-matthias commented Oct 7, 2025

CI runners that don't have LIBCLANG pre-installed would fail. We don't support Windows/MacOS for now, so we shouldn't do extra work with bindgen and cc.

This reverts commit 8054636.

Fixes #133

@not-matthias not-matthias requested a review from art049 October 7, 2025 08:42
CI runners that don't have LIBCLANG pre-installed would fail. We don't
support Windows/MacOS for now, so we shouldn't do extra work with
bindgen and cc.

This reverts commit 8054636.
@not-matthias not-matthias force-pushed the cod-1459-error-finding-libclang-in-github-actions-for-windows branch from 6da07fa to 5f43abd Compare October 7, 2025 08:48
Copy link

codspeed-hq bot commented Oct 7, 2025

CodSpeed Performance Report

Merging #134 will degrade performances by 47.87%

Comparing cod-1459-error-finding-libclang-in-github-actions-for-windows (9502f62) with main (112f30d)

Summary

⚡ 10 improvements
❌ 20 regressions
✅ 333 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
WallTime sum_fold 355 ns 304 ns +16.78%
WallTime small_drop 54 ns 61 ns -11.48%
WallTime large_setup 17 ns 22 ns -22.73%
WallTime iter_with_setup 48 ns 52 ns -7.69%
WallTime from_elem[16384] 992 ns 938 ns +5.76%
WallTime from_elem[4096] 366 ns 346 ns +5.78%
WallTime from_elem[8192] 558 ns 527 ns +5.88%
WallTime from_elem_decimal[2048] 282 ns 263 ns +7.22%
Instrumentation recursive[0] 211.1 ns 240.3 ns -12.14%
Instrumentation recursive[5] 291.1 ns 320.3 ns -9.11%
Instrumentation recursive_memoized[BTreeMap<u64, u64>, 0] 371.7 ns 342.5 ns +8.52%
WallTime generate_combinations[6] 2.1 µs 1.9 µs +6.88%
WallTime generate_combinations[7] 2.6 µs 2.8 µs -7.36%
WallTime generate_parentheses[3] 3.1 µs 3 µs +3.2%
WallTime graph_coloring[3] 1.6 µs 1.8 µs -12.84%
WallTime hamiltonian_cycle[5] 938 ns 899 ns +4.34%
WallTime hamiltonian_cycle[7] 1 µs 1.7 µs -38.87%
WallTime permutations[4] 3 µs 3.2 µs -3.79%
WallTime permutations[6] 66.8 µs 69.1 µs -3.35%
WallTime rat_in_maze[7] 923 ns 1,451 ns -36.39%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@not-matthias not-matthias force-pushed the cod-1459-error-finding-libclang-in-github-actions-for-windows branch from dfd9744 to d53c3ff Compare October 7, 2025 09:26
@not-matthias not-matthias force-pushed the cod-1459-error-finding-libclang-in-github-actions-for-windows branch from d53c3ff to 9502f62 Compare October 7, 2025 12:13
@art049 art049 merged commit 9502f62 into main Oct 7, 2025
30 of 35 checks passed
@art049 art049 deleted the cod-1459-error-finding-libclang-in-github-actions-for-windows branch October 7, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on all version 4 releases on x86_64_unknown_linux_gnu
2 participants