Skip to content

Conversation

art049
Copy link
Member

@art049 art049 commented Oct 8, 2025

  • fix: force C17 to build instrumenthooks
  • ci: check build with gcc-15

Fixes #133

@art049 art049 requested review from GuillaumeLagrange and not-matthias and removed request for GuillaumeLagrange October 8, 2025 10:17
@art049 art049 force-pushed the cod-1460-error-on-all-version-4-releases-on-x86_64_unknown_linux_gnu-2 branch from 8031565 to 807aa94 Compare October 8, 2025 10:25
@art049
Copy link
Member Author

art049 commented Oct 8, 2025

Unfortunately, it's really hard to have gcc-15 in the CI so we cannot add a regression test but it fixes the issue on the instance I used with GCC 15

Copy link

codspeed-hq bot commented Oct 8, 2025

CodSpeed Performance Report

Merging #136 will degrade performances by 13.55%

Comparing cod-1460-error-on-all-version-4-releases-on-x86_64_unknown_linux_gnu-2 (9e18b3a) with main (e64cdfa)

Summary

⚡ 8 improvements
❌ 11 regressions
✅ 301 untouched
⏩ 43 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
WallTime mut_borrow 8 ns 7 ns +14.29%
WallTime iterative[5] 7 ns 8 ns -12.5%
Instrumentation recursive[0] 211.1 ns 240.3 ns -12.14%
Instrumentation recursive[5] 291.1 ns 320.3 ns -9.11%
Instrumentation recursive_memoized[BTreeMap<u64, u64>, 0] 400.8 ns 371.7 ns +7.85%
WallTime generate_combinations[5] 1.2 µs 1.1 µs +7.19%
WallTime generate_combinations[7] 2.6 µs 2.5 µs +3.81%
WallTime generate_combinations[8] 4.9 µs 4.7 µs +4.63%
WallTime hamiltonian_cycle[5] 905 ns 950 ns -4.74%
WallTime permutations[3] 1,019 ns 872 ns +16.86%
WallTime permutations[7] 832.9 µs 796.4 µs +4.59%
WallTime rat_in_maze[7] 938 ns 1,085 ns -13.55%
WallTime generate_gray_code[2] 278 ns 291 ns -4.47%
Instrumentation sleep_100ns 536.9 ns 566.1 ns -5.15%
WallTime sleep_100ns 62.3 µs 21.7 µs ×2.9
Instrumentation sleep_100us 536.9 ns 566.1 ns -5.15%
Instrumentation sleep_1ms 536.9 ns 566.1 ns -5.15%
Instrumentation sleep_1ns 536.9 ns 566.1 ns -5.15%
Instrumentation sleep_1us 536.9 ns 566.1 ns -5.15%

Footnotes

  1. 43 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Co-authored-by: Matthias Heiden <matthias@codspeed.io>
@art049 art049 force-pushed the cod-1460-error-on-all-version-4-releases-on-x86_64_unknown_linux_gnu-2 branch from 807aa94 to 9e18b3a Compare October 8, 2025 10:46
@art049 art049 merged commit 9e18b3a into main Oct 8, 2025
14 of 18 checks passed
@art049 art049 deleted the cod-1460-error-on-all-version-4-releases-on-x86_64_unknown_linux_gnu-2 branch October 8, 2025 11:47
connortsui20 added a commit to vortex-data/vortex that referenced this pull request Oct 8, 2025
Fix coming from CodSpeedHQ/codspeed-rust#136

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error building compat layers with gcc > 15
1 participant