Skip to content

fix: do not display error when sending benchmark uri #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

not-matthias
Copy link
Member

Previous output (different project):

[11:15] not-matthias:perf-walltime-repo (main)> cargo codspeed run                                                                                                                                                                                                      devenv-shell-env
[cargo-codspeed] Measurement mode: Walltime

Collected 1 benchmark suite(s) to run
Running perf-walltime-repo my_benchmark
Timer precision: 24 ns
my_benchmark  fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ fibonacci                │               │               │               │         │
   ╰─ 32      Failed to send benchmark URI to runner: FIFO does not exist: /tmp/runner.ctl.fifo
4.382 ms      │ 11.75 ms      │ 5.129 ms      │ 5.862 ms      │ 510     │ 510

Done running my_benchmark
Finished running 1 benchmark suite(s)
No walltime benchmarks found

Works now as expected:

[11:22] not-matthias:divan_compat (cod-856-errror-log-in-walltime-when-running-without-codspeed)> cargo codspeed run                                                                                                                       devenv-shell-env
[cargo-codspeed] Measurement mode: Walltime

Collected 1 benchmark suite(s) to run
Running codspeed-divan-compat basic_example
Timer precision: 19 ns
basic_example       fastest       │ slowest       │ median        │ mean          │ samples │ iters
├─ fibo_10          0.135 ns      │ 1.141 ns      │ 0.207 ns      │ 0.22 ns       │ 100     │ 409600
├─ fibo_50          0.108 ns      │ 0.509 ns      │ 0.199 ns      │ 0.205 ns      │ 100     │ 409600
├─ mut_borrow       0.405 ns      │ 148 ns        │ 0.603 ns      │ 3.929 ns      │ 100     │ 25600
╰─ const_bench                    │               │               │               │         │
   ├─ bench_array1                │               │               │               │         │
   │  ├─ 1          0.107 ns      │ 0.287 ns      │ 0.11 ns       │ 0.125 ns      │ 100     │ 409600
   │  ├─ 4          5.386 ns      │ 5.849 ns      │ 5.401 ns      │ 5.409 ns      │ 100     │ 51200
   │  ├─ 10         7.784 ns      │ 19.87 ns      │ 7.866 ns      │ 8.061 ns      │ 100     │ 25600
   │  ╰─ 42         26.46 ns      │ 36.87 ns      │ 26.73 ns      │ 27.43 ns      │ 100     │ 12800
   ├─ bench_array2                │               │               │               │         │
   │  ├─ 1          0.032 ns      │ 0.37 ns       │ 0.108 ns      │ 0.108 ns      │ 100     │ 409600
   │  ├─ 4          4.521 ns      │ 5.552 ns      │ 4.534 ns      │ 4.554 ns      │ 100     │ 51200
   │  ├─ 10         6.569 ns      │ 8.569 ns      │ 6.636 ns      │ 6.658 ns      │ 100     │ 25600
   │  ╰─ 42         22.34 ns      │ 38.14 ns      │ 22.67 ns      │ 23.73 ns      │ 100     │ 12800
   ╰─ init_array                  │               │               │               │         │
      ├─ 4          4.522 ns      │ 7.954 ns      │ 4.542 ns      │ 4.983 ns      │ 100     │ 51200
      ├─ 42         22.3 ns       │ 29.2 ns       │ 22.59 ns      │ 22.71 ns      │ 100     │ 12800
      ╰─ 1000       513.3 ns      │ 1.078 µs      │ 551.1 ns      │ 557.2 ns      │ 100     │ 400

Done running basic_example
Finished running 1 benchmark suite(s)
No walltime benchmarks found

This comment was marked as off-topic.

This comment was marked as off-topic.

@not-matthias not-matthias force-pushed the cod-856-errror-log-in-walltime-when-running-without-codspeed branch from 0c80721 to 3c4118a Compare May 20, 2025 13:35
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very small change, you can also hunt for usage of this env var across the different crates, there are two or three scattered across already.

Also, watch out you left out a wip commit

@not-matthias not-matthias force-pushed the cod-856-errror-log-in-walltime-when-running-without-codspeed branch from c1d8c78 to 5caa771 Compare May 20, 2025 18:07
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@not-matthias not-matthias merged commit 5caa771 into main May 21, 2025
12 of 13 checks passed
@not-matthias not-matthias deleted the cod-856-errror-log-in-walltime-when-running-without-codspeed branch May 21, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants