Skip to content

Conversation

not-matthias
Copy link
Member

@not-matthias not-matthias commented Oct 3, 2025

Adding benchmark markers around the inner loop wouldn't help much, and likely just adds more work for little gain. However, I still bumped instrument-hooks since we added a few other features (version cmd, nonblocking IO, …)

@not-matthias not-matthias force-pushed the cod-1380-pytest-codspeed-add-perf-v2-support branch from 78032ba to 6d29be0 Compare October 3, 2025 12:06
Copy link

codspeed-hq bot commented Oct 3, 2025

CodSpeed Performance Report

Merging #87 will degrade performances by 24.91%

Comparing cod-1380-pytest-codspeed-add-perf-v2-support (f6a8a56) with master (192d881)

Summary

⚡ 15 improvements
❌ 14 (👁 14) regressions
✅ 138 untouched

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
👁 WallTime test_make_highpass 5.4 µs 5.5 µs -2.08%
WallTime test_color[graph0-3] 30 µs 29.3 µs +2.17%
WallTime test_combination_lists[5-4] 3.6 µs 3.5 µs +2.46%
WallTime test_combination_sum[candidates0-8] 11 µs 10.7 µs +2.16%
👁 WallTime test_depth_first_search[4] 30.3 µs 30.9 µs -2.18%
WallTime test_generate_all_combinations[0-0] 1.4 µs 1.3 µs +5.95%
WallTime test_generate_all_permutations[sequence1] 165 µs 161.8 µs +2.03%
WallTime test_generate_sum_of_subsets_soln[nums0-9] 24.9 µs 24.3 µs +2.74%
WallTime test_is_complete[board0] 1.8 µs 1.7 µs +8.43%
👁 WallTime test_match_word_pattern[aba-GraphTreesGraph] 102.2 µs 105.5 µs -3.18%
👁 WallTime test_sudoku[initial_grid0] 8.1 µs 8.7 µs -7.63%
👁 WallTime test_sum_squares_slow 289.1 µs 300.5 µs -3.79%
WallTime test_recursive_cached_fibo_100 141.2 µs 136.9 µs +3.18%
👁 WallTime test_recursive_fibo_10 41.9 µs 45.2 µs -7.19%
👁 WallTime test_recursive_fibo_20 4.8 ms 5.5 ms -11.93%
WallTime test_count_even[count_even_slow] 1.5 ms 1.4 ms +6.71%
WallTime test_sum_of_squares[sum_of_squares_for_loop_power] 215.2 µs 190.7 µs +12.87%
WallTime test_sum_of_squares[sum_of_squares_sum_comprehension_power] 233.8 µs 221.2 µs +5.71%
WallTime test_sum_of_squares[sum_of_squares_sum_comprehension_product] 196.5 µs 189.8 µs +3.51%
👁 WallTime test_sum_of_squares[sum_of_squares_sum_labmda_product] 253.6 µs 265.1 µs -4.32%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@not-matthias not-matthias force-pushed the cod-1380-pytest-codspeed-add-perf-v2-support branch 4 times, most recently from b11f157 to 934ed90 Compare October 3, 2025 12:53
@not-matthias not-matthias requested a review from art049 October 3, 2025 13:45
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the issue on the duplication of the marker type value, otherwise lgtm

@not-matthias not-matthias force-pushed the cod-1380-pytest-codspeed-add-perf-v2-support branch 2 times, most recently from 6230c08 to 68fde1a Compare October 6, 2025 09:53
@not-matthias not-matthias force-pushed the cod-1380-pytest-codspeed-add-perf-v2-support branch 3 times, most recently from d928e97 to cac2943 Compare October 6, 2025 13:48
@not-matthias not-matthias requested a review from art049 October 6, 2025 13:48
@art049
Copy link
Member

art049 commented Oct 6, 2025

Seems like there is a build issue @not-matthias

@not-matthias not-matthias force-pushed the cod-1380-pytest-codspeed-add-perf-v2-support branch from cac2943 to f6a8a56 Compare October 6, 2025 14:33
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@art049 art049 merged commit 63eec3b into master Oct 6, 2025
32 checks passed
@art049 art049 deleted the cod-1380-pytest-codspeed-add-perf-v2-support branch October 6, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants