-
Notifications
You must be signed in to change notification settings - Fork 14
chore: bump instrument-hooks #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
78032ba
to
6d29be0
Compare
CodSpeed Performance ReportMerging #87 will degrade performances by 24.91%Comparing Summary
Benchmarks breakdown
|
b11f157
to
934ed90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the issue on the duplication of the marker type value, otherwise lgtm
6230c08
to
68fde1a
Compare
d928e97
to
cac2943
Compare
Seems like there is a build issue @not-matthias |
cac2943
to
f6a8a56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Adding benchmark markers around the inner loop wouldn't help much, and likely just adds more work for little gain. However, I still bumped instrument-hooks since we added a few other features (version cmd, nonblocking IO, …)