Get code coverage back over 80% #20
Assignees
Labels
Comments
|
I actually disabled the tests. Will fix them, worry nawt! |
|
Erm, when? I can also see that they've been running in the last 10 or so builds. |
|
I can also see that the coverage fell after my commit, so this issue is mine !! |
ayld
added a commit
that referenced
this issue
May 24, 2015
- integration tests were not working on windows due to "linux style" slashes in the paths, all slashes replaced with dots now - replaced junit.framework.Assert with org.junit.Assert due to deprecation
|
haha |
ayld
added a commit
that referenced
this issue
Jun 7, 2015
- added MinimizationStrategy concept, with the intent of it using the "services" and using DI, so we can unit test the base logic - some of the configuration is now moved out of the minimizer - added "unit" test for the new minimization strategy - Files is no longer final as it can't be mocked :( will have to probably use powermock as I hate non-final stuff when it should be final
|
Win! Coverage is up by 5%. |
ayld
pushed a commit
that referenced
this issue
Jun 19, 2015
- also JdkToolCalls now clears args state after successful execution
ayld
pushed a commit
that referenced
this issue
Jun 24, 2015
- added separate non-integration test for the indexed minimizer - added a size() method to the index, returning count of currently index class nodes - added test for the new method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
So fixing #19 dropped test coverage by 20%, because it turns out 20% of all tests were integration tests, which is not ideal, to say the least :D
The Minimizer should be unit tested! If it can not be unit tested, it should be cut down and then unit tested mercilessly!
Overall the goal of this issue is to get coverage back to ~80%
The text was updated successfully, but these errors were encountered: