Skip to content

[CHE 126] Add Remaining Profile Info To Edit Profile Form #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 53 commits into from
Jun 14, 2024
Merged

[CHE 126] Add Remaining Profile Info To Edit Profile Form #129

merged 53 commits into from
Jun 14, 2024

Conversation

Mnelson98
Copy link

@Mnelson98 Mnelson98 commented Jun 3, 2024 •
edited
Loading

Description

As part of CHE-113 story "profiles improvement", this PR adds profile information to the edit profile form.

Jira Task

CHE-126

Testing Instructions

  1. Make sure all branches are up to date and you are working from feature branch
  2. Spin up the dev environment and log in
  3. Navigate to the edit profile page
  4. Edit the information in each category
  5. Hit the "Save Changes" button
  6. Navigate back to the edit profile page and ensure all changes were saved to the profile

Checklist

All Team Members

  • I added a descriptive title to this PR.
  • I filled out the Description, Jira Task, and Testing Instructions sections above.
  • I added or updated [Jest unit tests]for any changes to components, server-side controllers, etc.
  • I ran npm run docker-test in my local environment to check that this PR passes all unit tests.
  • I did a quick check to make sure my code changes follow the recommended style guide.

Additional Notes, Images, etc.

N/A

Mnelson98 added 27 commits May 24, 2024 13:50
@Mnelson98
added nickname to EditProfile form
9bae8b2
@Mnelson98
Added first and last name to edit profile page
f8ee042
@Mnelson98
Merge branch 'CHE-113/story/Profiles-Improvements' into CHE-126/subta…
826012f 
…sk/Add-Remaining-Profile-Info-To-EditProfile-Form
@Mnelson98
Added Cohort and LinkedIn to edit profile page
b9c1d18
@Mnelson98
Edited skills field in profile schema to enable the desired add and r…
d92c740 
…emove functionality
@Mnelson98
#1 - added skills add and delete functionality. Created the skills fi…
8f9f8ce 
…eld. Updated the profile schema to enable desired functionality(skills from string to array).
@Mnelson98
#2 updated styling for skills and updated the skills section of the p…
08de18c 
…rofileModel
@Mnelson98
removed unnecessary skills path
2bae176
@Mnelson98
removed first and last name from the form
82ef8bf
@Mnelson98
added nickname to profile controller and built functionality for edit…
c308ff1 
… page H1 to either reference the users firstname unless a nickname is given
@Mnelson98
updated to be camelCased where used
d6ad7f9
@Mnelson98
restyled personalBio box to be expandable and set a character limit
ce91cda
@Mnelson98
added GitHub to user profile
c94a018
@Mnelson98
matching GitHub references
905ba59
@Mnelson98
updated GitHub typing
8fc205d
@Mnelson98
adding nickname and GitHub typing to FE
08d7b21
@Mnelson98
destructuring specilizations in profile controller and created specia…
7499d4f 
…lization checkbox within each listed user skill
@Mnelson98
built specialization add and remove functionality
075338a
@Mnelson98
removed comments
d9ed0c3
@Mnelson98
stopping specialization from being removed when it is selected twice
fc76aba
@Mnelson98
added current company and title to the page
872f38e
@Mnelson98
added socialMedia to profileController update function
2504ed5
@Mnelson98
added twitter and blog links
fad04fe
@Mnelson98
added networking availability to the form
64e2df9
@Mnelson98
removing comments and console.logs
d179ca7
@Mnelson98
rearranged event handlers
bd75fbe
@Mnelson98
refactored class names
6280c8b
@Mnelson98 Mnelson98 added the enhancement New feature or request label Jun 3, 2024
@Mnelson98 Mnelson98 self-assigned this Jun 3, 2024
@Mnelson98 Mnelson98 changed the title [CHE 147] Add Remaining Profile Info To Edit Profile Form [CHE 126] Add Remaining Profile Info To Edit Profile Form Jun 3, 2024
Mnelson98
Mnelson98 commented Jun 10, 2024
View reviewed changes
seantokuzo
seantokuzo reviewed Jun 12, 2024
View reviewed changes
seantokuzo
seantokuzo reviewed Jun 12, 2024
View reviewed changes
seantokuzo
seantokuzo reviewed Jun 12, 2024
View reviewed changes
seantokuzo
seantokuzo reviewed Jun 12, 2024
View reviewed changes
seantokuzo
seantokuzo reviewed Jun 12, 2024
View reviewed changes
seantokuzo
seantokuzo reviewed Jun 12, 2024
View reviewed changes
seantokuzo
seantokuzo requested changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@seantokuzo seantokuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this beast of a ticket Micah! I left a few comments for review, but everything is coming together very nice. I love the UX of the skills/specializations section - just filled out my profile on Indeed and was wishing their UX for adding skills was as good as this

@brok3turtl3 brok3turtl3 requested a review from seantokuzo June 14, 2024 16:08
seantokuzo
seantokuzo requested changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@seantokuzo seantokuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working great! Just one quick fix in handleSubmit and I think we're good to go! Great job Micah! 💥

@seantokuzo seantokuzo self-requested a review June 14, 2024 19:02
seantokuzo
seantokuzo approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@seantokuzo seantokuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LETS GOOOO!!! Hulk, smash that merge!

@brok3turtl3
Copy link
Contributor

Awesome job on this one @Mnelson98 - Great ticket! 🎉

@brok3turtl3 brok3turtl3 merged commit 0ea91c2 into CHE-113/story/Profiles-Improvements Jun 14, 2024
@brok3turtl3 brok3turtl3 deleted the CHE-126/subtask/Add-Remaining-Profile-Info-To-EditProfile-Form branch June 14, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seantokuzo seantokuzo seantokuzo approved these changes

@jimpulsee jimpulsee Awaiting requested review from jimpulsee

@brok3turtl3 brok3turtl3 Awaiting requested review from brok3turtl3

Assignees

@Mnelson98 Mnelson98

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mnelson98 @brok3turtl3 @seantokuzo @jimpulsee