Skip to content

Conversation

timakin
Copy link
Contributor

@timakin timakin commented Apr 11, 2017

Overview

With staticcheck command, the fatal errors on context_test appears on a console.

$ staticcheck
context_test.go:25:2: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (SA2002)
context_test.go:105:2: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (SA2002)

So changed not to use t.Fatal as fatal case of goroutine

Reference

https://github.com/prometheus/node_exporter/pull/439/files

@coveralls
Copy link

coveralls commented Apr 11, 2017

Coverage Status

Coverage remained the same at 90.0% when pulling d827531 on timakin:fix/staticcheck-fatal into 66e76ef on Code-Hex:master.

@Code-Hex
Copy link
Owner

Code-Hex commented Apr 11, 2017

@timakin Thanks!!

@Code-Hex Code-Hex merged commit 05e1d0f into Code-Hex:master Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants