Skip to content

Standard name comes from this directory's name #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Aug 3, 2020

Now we are called "codeatcs" :( (currently comes from the package directory name)

kép

See for example https://github.com/slevomat/coding-standard/tree/master/SlevomatCodingStandard

@szepeviktor
Copy link
Contributor Author

@Mte90
Copy link
Member

Mte90 commented Aug 3, 2020

So the name is generated by the folder I don't understand why is lowercase.
I know that composer requires names lowercase but is not happening with the others. I guess because they have subfolders.

@Mte90 Mte90 merged commit dde2496 into CodeAtCode:master Aug 3, 2020
@szepeviktor szepeviktor deleted the patch-1 branch August 3, 2020 13:40
@szepeviktor
Copy link
Contributor Author

Add this CodeatCodingStandard directory makes it perfect!

@szepeviktor
Copy link
Contributor Author

Now we're talking!

$ vendor/bin/phpcs -i
CodeatCodingStandard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants