Skip to content

Conversation

kakao-jun-e
Copy link
Contributor

To merge the detailed values of RPC into one config value in blake/cuckoo miner

pub struct CuckooConfig {
    pub max_vertex: usize,
    pub max_edge: usize,
    pub cycle_length: usize,

    pub listening_port: u16,
    pub submitting_port: u16,

    pub concurrent_jobs: u16,
}

->

pub struct CuckooConfig {
    pub max_vertex: usize,
    pub max_edge: usize,
    pub cycle_length: usize,

    pub rpc_config: RpcConfig,
    
    pub concurrent_jobs: u16,
}

Copy link

@sgkim126 sgkim126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not object to this patch, but I think it's right to derive Copy too.

@kakao-jun-e
Copy link
Contributor Author

kakao-jun-e commented Sep 12, 2018

@sgkim126 sgkim126 merged commit 820e11e into CodeChain-io:master Sep 12, 2018
@kakao-jun-e kakao-jun-e deleted the add_clone_trait branch September 27, 2018 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants