Remove compose and decompose transaction #1775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you organize removing tasks in Github Project? |
foriequal0
requested changes
Sep 20, 2019
| @@ -122,9 +124,11 @@ impl CommonParams { | |||
| pub fn min_asset_supply_increase_cost(&self) -> u64 { | |||
| self.min_asset_supply_increase_cost | |||
| } | |||
| /// Deprecated | |||
| pub fn min_asset_compose_cost(&self) -> u64 { | |||
There was a problem hiding this comment.
Is this function still used? If it is not used then it should be removed, otherwise, #[deprecated] attribute is a better choice I think.
There was a problem hiding this comment.
I added deprecated!
majecty
force-pushed
the
f/remove-compose
branch
from
c4c98dd to
2148a22
Compare
|
@foriequal0 I applied your comments. Could you check it? |
majecty
force-pushed
the
f/remove-compose
branch
from
2148a22 to
47bf363
Compare
foriequal0
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.