Release 2.2.1 #1867
Merged
Release 2.2.1 #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remagpie
previously approved these changes
Nov 15, 2019
sgkim126
previously approved these changes
Nov 19, 2019
This reverts commit 59e9ebd.
In the Tendermint restoring process, if the backup state is the Commit step, CodeChain set the step to the Precommit step and handles the votes. The purpose of the behavior is that calling functions that are called when enters the Commit state. Changing the "step" in the restoring process is fragile. It is easy to miss to set some variables. The `finalized_view_of_current_block` variable should be changed when the step is changed. It was lost before. This commit fixes the problem by ignoring the assertion check in the restore process. Although it is not a perfect solution, it is consistent. There is some code already do differently in the restore process.
foriequal0
dismissed stale reviews from sgkim126, majecty, and remagpie
via
305e732
|
@foriequal0 and @majecty decided to revert previous hotfix #1866 and proceed the release of 2.2.1 with #1871. |
majecty
approved these changes
Nov 19, 2019
sgkim126
approved these changes
Nov 19, 2019
remagpie
approved these changes
Nov 20, 2019
|
I forgot to cherry-pick this #1858 😞. I manually cherry-picked it and pushed it. It won't break the build since it only touches the CI post-processing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Bugfixes:
Set finalized_view to None when restoring in the Commit step Set finalized_view to None when restoring in the Commit step #1866Reverted, and replaced by Do not assert the finalized_view while restoring #1871