Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2.1 #1867

Merged
merged 3 commits into from
Nov 20, 2019
Merged

Release 2.2.1 #1867

merged 3 commits into from
Nov 20, 2019

Conversation

foriequal0
Copy link
Contributor

@foriequal0 foriequal0 commented Nov 15, 2019

Changelog

Bugfixes:

remagpie
remagpie previously approved these changes Nov 15, 2019
majecty
majecty previously approved these changes Nov 18, 2019
Copy link
Contributor

@majecty majecty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

sgkim126
sgkim126 previously approved these changes Nov 19, 2019
foriequal0 and others added 3 commits November 19, 2019 17:13
In the Tendermint restoring process, if the backup state is the Commit
step, CodeChain set the step to the Precommit step and handles the
votes. The purpose of the behavior is that calling functions that are
called when enters the Commit state.

Changing the "step" in the restoring process is fragile. It is easy to
miss to set some variables. The `finalized_view_of_current_block`
variable should be changed when the step is changed. It was lost
before.

This commit fixes the problem by ignoring the assertion check in the
restore process. Although it is not a perfect solution, it is
consistent. There is some code already do differently in the restore
process.
@foriequal0
Copy link
Contributor Author

@foriequal0 and @majecty decided to revert previous hotfix #1866 and proceed the release of 2.2.1 with #1871.

@foriequal0 foriequal0 merged commit 9deef2a into CodeChain-io:rc-2.2.x Nov 20, 2019
@foriequal0 foriequal0 deleted the 2.2.1 branch November 20, 2019 04:45
@foriequal0
Copy link
Contributor Author

foriequal0 commented Nov 20, 2019

I forgot to cherry-pick this #1858 😞. I manually cherry-picked it and pushed it. It won't break the build since it only touches the CI post-processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants