Skip to content

Conversation

majecty
Copy link
Contributor

@majecty majecty commented Nov 15, 2019

In the Tendermint restoring process, if the backup state is the Commit
step, CodeChain set the step to the Precommit step and handles the
votes. The purpose of the behavior is that calling functions that are
called when enters the Commit state.

After we introduce the finalized_view_of_current_block variable, the
variable should be changed to None when CodeChain sets the state to
Precommit in the restoring process.

In the Tendermint restoring process, if the backup state is the Commit
step, CodeChain set the step to the Precommit step and handles the
votes. The purpose of the behavior is that calling functions that are
called when enters the Commit state.

After we introduce the `finalized_view_of_current_block` variable, the
variable should be changed to `None` when CodeChain sets the state to
Precommit in the restoring process.
Copy link
Contributor

@remagpie remagpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working.

@foriequal0 foriequal0 merged commit 59e9ebd into CodeChain-io:rc-2.2.0 Nov 15, 2019
@foriequal0
Copy link
Contributor

foriequal0 commented Nov 15, 2019

Oh we should've made rc-2.2.x branch first according to the release manual.

@majecty majecty deleted the f/fix-tendermint-restore branch November 18, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants