Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Status bar #38

Closed
Tracked by #346
austincondiff opened this issue Mar 17, 2022 · 4 comments · Fixed by #99
Closed
Tracked by #346

✨ Status bar #38

austincondiff opened this issue Mar 17, 2022 · 4 comments · Fixed by #99
Assignees
@lukepistrol
Labels
enhancement New feature or request UI This is UI related

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 17, 2022 •
edited
Loading

image

This should be togglable between visible and hidden in the view menu and in preferences.
@austincondiff austincondiff added the enhancement New feature or request label Mar 17, 2022
@lukepistrol lukepistrol self-assigned this Mar 19, 2022
@lukepistrol lukepistrol mentioned this issue Mar 19, 2022
Merged
@lukepistrol lukepistrol added the UI This is UI related label Mar 20, 2022
@lukepistrol lukepistrol linked a pull request Mar 20, 2022 that will close this issue
Basic implementation of the status bar (non interactive) #99
Merged
@lukepistrol
Copy link
Member

Current state. Just dummy elements at the moment.

Screen Shot 2022-03-20 at 01 23 37

Screen.Recording.2022-03-20.at.01.27.33.mov

@lukepistrol
Copy link
Member

Update on current state:

Screen Shot 2022-03-20 at 14 27 27

Preview.mov

@lukepistrol lukepistrol reopened this Mar 20, 2022
@austincondiff
Copy link
Collaborator Author

austincondiff commented Mar 21, 2022 •
edited
Loading

Love it! 😍

image

Padding, spacing, font-sizes and dimensions are slightly off (everything seems a little too big), please refer to the figma concept for exact specifications.

The drawer should also animate open and closed when toggled.

@lukepistrol
Copy link
Member

lukepistrol commented Mar 21, 2022 •
edited
Loading

Todo:

  • fix padding/spacing
  • fix font-size
  • animate open behavior

@lukepistrol lukepistrol changed the title Status bar [FEAT] - Status bar Mar 21, 2022
@lukepistrol lukepistrol mentioned this issue Mar 21, 2022
Merged
@MarcoCarnevali MarcoCarnevali mentioned this issue Mar 21, 2022
Merged
4 tasks
@lukepistrol lukepistrol mentioned this issue Mar 21, 2022
Merged
4 tasks
@austincondiff austincondiff changed the title [FEAT] - Status bar ✨ Status bar Mar 31, 2022
@austincondiff austincondiff mentioned this issue Mar 31, 2022
Open
12 tasks
@austincondiff austincondiff moved this from 🆕 New to 🏁 Complete in CodeEdit Project Feb 14, 2023
xinix909 pushed a commit to xinix909/CodeTransfer that referenced this issue Sep 7, 2024
@Sophiahooley @FastestMolasses
Toggle comment for current line via CMD + / (CodeEditApp#241)
dae56c8 
This change implements the functionality of <kbd>⌘</kbd> <kbd>/</kbd>
for single line comments. It allows you to toggle between commented and
uncommented for the line the cursor is currently on when you press
<kbd>⌘</kbd> <kbd>/</kbd>.

To do so, I implemented a `keyDown` event recognizer, which listens for
when the relevant keys are pressed. If <kbd>⌘</kbd> <kbd>/</kbd> is
pressed, it calls a method called `commandSlashCalled()`, which decides
which toggle is supposed to happen depending on if the line is already
commented or not. It also addresses the situation of special cases of
languages like HTML, which need a comment at the beginning and end of
the line (essentially a `rangeComment`) to comment a single line.

### Related Issues

- CodeEditApp#38

This PR accomplishes part of CodeEditApp#38. I talked with some of the project
leads (@FastestMolasses) and they said it makes sense to break CodeEditApp#38 into
a couple different issues (I.e. single-line vs highlighted chunks, etc).
Single-line comment toggling is completed as of this PR but commenting
highlighted code still needs to be completed.

### Checklist

- [x] I read and understood the [contributing
guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md)
as well as the [code of
conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)
- [x] The issues this PR addresses are related to each other
- [x] My changes generate no new warnings
- [x] My code builds and runs on my machine
- [x] My changes are all related to the related issue above
- [x] I documented my code

### Screenshots

<img width="626" alt="Screenshot 2024-04-19 at 5 44 24 PM"
src="https://github.com/CodeEditApp/CodeEditSourceEditor/assets/143217945/1200a5c1-d8ea-48a4-9704-70db7aa23fc7">

---------

Co-authored-by: Abe <abe.malla8@gmail.com>
xinix909 pushed a commit to xinix909/CodeTransfer that referenced this issue Sep 7, 2024
@thecoolwinter
Fix Page Up/Down Keys (CodeEditApp#38)
9e6d94a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukepistrol lukepistrol

Labels
enhancement New feature or request UI This is UI related
Projects
CodeEdit Project
Status: 🏁 Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Basic implementation of the status bar (non interactive) lukepistrol/CodeEdit
2 participants
@austincondiff @lukepistrol