Unified about window #1010
Merged
Unified about window #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the same window and transitioning between them.
|
This is the animation bug I am referring to above. I spent about 4 or 5 hours trying to fix this trying different variations in howI am structuring my code. I will need some help fixing this. Screen.Recording.2023-01-20.at.6.29.04.PM.movThis is caused by the these lines of code. This padding enables the titlebar from blocking the scrollable content so content is not seen in the titlebar area. It also prevents the icon from animating over content during animation in a scrolled state. |
austincondiff
requested review from
Wouter01,
lukepistrol,
0xWDG,
matthijseikelenboom and
bombardier200
matthijseikelenboom
previously approved these changes
Jan 21, 2023
lukepistrol
reviewed
Jan 21, 2023
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
0xWDG
previously approved these changes
Jan 22, 2023
austincondiff
force-pushed
the
unified-about-window-with-transitions
branch
from
6d4bae1 to
83d839d
Compare
austincondiff
requested review from
matthijseikelenboom,
0xWDG and
lukepistrol
|
Okay, fixed everything. Transitions are now seamless. Updated video in PR description. |
0xWDG
approved these changes
Jan 22, 2023
Wouter01
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unified the about window by moving contributors and acknowledgement view in the same window and transitioning between them.
Note: There is a bug in the title animation and I will need some help fixing it. It seems like a SwiftUI but but I am not sure. See code for details.
Checklist
Screenshots
Screen_Recording_2023-01-22_at_3.25.21_PM.mov