Skip to content

Scroll to tab #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2023
Merged

Scroll to tab #1085

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52ffe9d
Added scroll to tab when opening new tabs.
maxkel Feb 25, 2023
fd9236f
Merge branch 'CodeEditApp:main' into main
maxkel Feb 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CodeEdit/Features/TabBar/Views/TabBarView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,16 @@ struct TabBarView: View {
// On first tab appeared, jump to the corresponding position.
scrollReader.scrollTo(workspace.selectionState.selectedId)
}
.onChange(of: workspace.selectionState.openedTabs) { _ in
DispatchQueue.main.asyncAfter(
deadline: .now() + .milliseconds(
prefs.preferences.general.tabBarStyle == .native ? 150 : 200
)
) {
guard let selectedID = workspace.selectionState.selectedId else { return }
scrollReader.scrollTo(selectedID)
}
}
// When selected tab is changed, scroll to it if possible.
.onChange(of: workspace.selectionState.selectedId) { targetId in
guard let selectedId = targetId else { return }
Expand Down