Skip to content

Update Clone From label in Account Preferences #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2023
Merged

Update Clone From label in Account Preferences #987

merged 1 commit into from
Jan 16, 2023

Conversation

MrDevel0per
Copy link
Contributor

@MrDevel0per MrDevel0per commented Jan 16, 2023 •
edited
Loading

I updated the label to display the correct clone source. Instead of always displaying HTTPS, it will now display the correct provider.

Description

Fixed the Clone From text in the AccountPreferencesView. Now, instead of always displaying HTTPS, it will display the correct source based on the above Picker's selection. If the Picker is set to SSH, it will now say:

New repositories will be cloned from GitHub using SSH.

Related Issue

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

Screenshot 2023-01-16 at 1 28 32 PM

@MrDevel0per
Updated clone label
68d4979 
I updated the label to display the correct clone source. Instead of always displaying HTTPS, it will now display the correct provider.
@Wouter01 Wouter01 merged commit 4e0b5b0 into CodeEditApp:main Jan 16, 2023
@ben-p-commits ben-p-commits mentioned this pull request Jan 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff left review comments

@lukepistrol lukepistrol lukepistrol approved these changes

@Wouter01 Wouter01 Wouter01 approved these changes

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrDevel0per @austincondiff @lukepistrol @Wouter01