Bump STTextView Version #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austincondiff
requested review from
austincondiff,
lukepistrol and
thecoolwinter
austincondiff
previously approved these changes
Feb 6, 2023
lukepistrol
previously approved these changes
Feb 6, 2023
|
Not sure what to do about the tests failing. Content Inset is being reset to zero here, and the commit message suggests over-scroll did not work as intended. How do you folks want to proceed? @austincondiff @lukepistrol ? |
denil-ct
dismissed stale reviews from lukepistrol and austincondiff
via
c423453
denil-ct
requested review from
austincondiff and
lukepistrol
and removed request for
austincondiff and
thecoolwinter
|
Tests have been fixed. |
denil-ct
requested review from
austincondiff
and removed request for
lukepistrol
thecoolwinter
approved these changes
Feb 8, 2023
|
Thank you @denil-ct! I saw all your discussion on the STTextView repo, sorry this took so long to get reviewed. |
This was referenced Feb 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump STTextView version to latest, as it includes a fix for scroll performance and content rendering in large files.
For more info see this discussion.