Skip to content

Conversation

mschechter-bellese
Copy link
Collaborator

Description

  • Added new endpoints and types
  • Added additional reference types
  • Cleaned up regular expressions
  • Fixed cut-and-paste errors

Resolves #270

Related PRs

List related PRs against other branches:

branch PR
Initial API rework #254
API rework for authentication #256
API rework for roles #259
API rework for role grants #260
API rework for users #263
API rework for contacts #276

Todos

  • Tests
  • Documentation

Deploy Notes

  • N/A

Steps to Test or Reproduce

Impacted Areas in Application

List general components of the application that this PR will affect:

  • Contract definition

- Added new endpoints and types
- Added additional reference types
- Cleaned up regular expressions
- Fixed cut-and-paste errors
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #277 into master will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   86.83%   87.08%   +0.24%     
==========================================
  Files          17       17              
  Lines         638      720      +82     
==========================================
+ Hits          554      627      +73     
- Misses         84       93       +9     
Impacted Files Coverage Δ
src/routes/csv.js 82.60% <0.00%> (-4.90%) ⬇️
src/routes/contact.js 86.47% <0.00%> (-0.67%) ⬇️
src/utils/index.js 88.70% <0.00%> (+0.18%) ⬆️
src/utils/login.js 92.85% <0.00%> (+1.19%) ⬆️
src/index.js 96.29% <0.00%> (+2.41%) ⬆️
src/utils/response.js 100.00% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a473d...bc7e5e0. Read the comment docs.

@mschechter-bellese mschechter-bellese changed the base branch from master to mschechter-bellese/issue-262 September 18, 2020 12:28
@mschechter-bellese mschechter-bellese changed the base branch from mschechter-bellese/issue-262 to mschechter-bellese/issue-271 September 18, 2020 12:32
This was referenced Sep 18, 2020
Base automatically changed from mschechter-bellese/issue-271 to epic/api-2.0.0 October 2, 2020 17:17
@mschechter-bellese mschechter-bellese merged commit 6195e13 into epic/api-2.0.0 Oct 2, 2020
@mschechter-bellese mschechter-bellese deleted the mschecter-bellese/issue-270 branch October 2, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review entity contracts

2 participants