Replaced organization github name and project repo fields with Project github url #286
Conversation
|
@sai92messy this looks like a great simplification - thank you! 🎉 Could you please add a screenshot of how this has changed the Project Submission user interface? Thanks! |
|
@DBNess Great. Here is the screenshot showing the changes |
| @@ -13,7 +13,7 @@ class Organization < ActiveRecord::Base | |||
| attr_accessor :is_public_submission | |||
|
|
|||
| validates_presence_of :name | |||
| validates_presence_of :github_org, if: :is_public_submission | |||
| # validates_presence_of :github_org, if: :is_public_submission | |||
There was a problem hiding this comment.
Would you please remove commented out code? Thanks!
|
@sai92messy - Thanks so much for this contribution! I love how simple and agile it is, even down to your front end changes. And you even remembered to update the tests! 💯 I've left some comments with changes I would love to see before we merge this into the code base. Let me know if you have any questions, because I'm really looking forward to merging! |
|
Related to #243. |
sai92messy
force-pushed
the
giturlparser
branch
from
ef1004b
to
1559ab6
Compare
| @@ -43,9 +43,16 @@ def logo_delete | |||
| @logo_delete || '0' | |||
| end | |||
|
|
|||
| def set_github_org | |||
| if self.projects.first | |||
| self.github_org = Project.parse_git_url(self.projects.first.submitted_github_url).split('/').first | |||
There was a problem hiding this comment.
Line is too long. [104/80]
Redundant self detected.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
sai92messy
force-pushed
the
giturlparser
branch
from
1559ab6
to
52b1f19
Compare
|
|
||
| def set_github_org | ||
| if projects.first | ||
| github_org = Project.parse_git_url(projects.first.submitted_github_url) |
There was a problem hiding this comment.
Useless assignment to variable - github_org.
| private | ||
|
|
||
| def set_github_repo | ||
| github_repo = Project.parse_git_url(submitted_github_url).split('/').last |
There was a problem hiding this comment.
Useless assignment to variable - github_repo.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
…t github url, Parse github url to get organization github name and project git repo
sai92messy
force-pushed
the
giturlparser
branch
from
52b1f19
to
2e62bb8
Compare
|
|
||
| def set_github_org | ||
| if projects.first | ||
| self.github_org = Project.parse_git_url(projects.first.submitted_github_url) |
Replaced organization github name and project repo fields with Project github url.
When user enters the Project github url the system parses the url and finds the respective Organization name and Project repo name.