ls: add -a (include dotfiles) and accept -1 (one-per-line)

Author: Pezhman-Azizi

implement-shell-tools/ls/ls.js

@@ -1,47 +1,73 @@
 #!/usr/bin/env node
-// ls.js — ESM basic version (no flags)
-// - If no paths: list '.'
-// - Excludes dotfiles by default
-// - One entry per line, alphabetical
-// - Multiple paths: print "path:" header before each directory group
-// - GNU-like errors; exit code 1 on any failure
+
 
 import fs from "node:fs";
 import { pathToFileURL } from "node:url";
 
-const args = process.argv.slice(2);
-const targets = args.length ? args : ["."];
-let hadError = false;
+const raw = process.argv.slice(2);
 
-for (let i = 0; i < targets.length; i++) {
-  const target = targets[i];
+let includeAll = false;   // -a
+let onePerLine = false;   // -1 (format already one-per-line)
+const targets = [];
 
+// Parse flags (supports combined like -a1 / -1a). Treat lone "-" as a path.
+for (const arg of raw) {
+  if (arg === "-" || !arg.startsWith("-")) {
+    targets.push(arg);
+    continue;
+  }
+  if (arg === "-1") {
+    onePerLine = true;
+    continue;
+  }
+  for (const ch of arg.slice(1)) {
+    if (ch === "a") includeAll = true;
+    else if (ch === "1") onePerLine = true;
+    else {
+      // ignore unknown short flags
+    }
+  }
+}
+
+const paths = targets.length ? targets : ["."];
+let hadError = false;
+
+for (let i = 0; i < paths.length; i++) {
+  const p = paths[i];
   try {
-    const stat = await fs.promises.lstat(target);
+    const st = await fs.promises.lstat(p);
+
+    if (st.isDirectory()) {
+      if (paths.length > 1) console.log(`${p}:`);
 
-    if (stat.isDirectory()) {
-      if (targets.length > 1) console.log(`${target}:`);
+      const entries = await fs.promises.readdir(p, { withFileTypes: true });
+      let names = entries.map(d => d.name);
 
-      const entries = await fs.promises.readdir(target, { withFileTypes: true });
-      const names = entries
-        .map(d => d.name)
-        .filter(n => !n.startsWith("."))               // no dotfiles (we’ll add -a later)
-        .sort((a, b) => a.localeCompare(b));
+      if (!includeAll) {
+        names = names.filter(n => !n.startsWith("."));
+      } else {
+        // mimic `ls -a` by including "." and ".."
+        names = ["." , "..", ...names];
+      }
 
-      for (const name of names) console.log(name);
+      names.sort((a, b) => a.localeCompare(b));
+      for (const name of names) {
+        // one-per-line output; -1 flag just affirms it
+        console.log(name);
+      }
 
-      if (targets.length > 1 && i !== targets.length - 1) console.log(""); // blank line between dir groups
+      if (paths.length > 1 && i !== paths.length - 1) console.log("");
     } else {
-      // plain file or symlink -> print the argument as given
-      console.log(target);
+      // file or symlink => print the argument as given
+      console.log(p);
     }
   } catch (err) {
     if (err?.code === "ENOENT") {
-      console.error(`ls: cannot access '${target}': No such file or directory`);
+      console.error(`ls: cannot access '${p}': No such file or directory`);
     } else if (err?.code === "EACCES") {
-      console.error(`ls: cannot open directory '${target}': Permission denied`);
+      console.error(`ls: cannot open directory '${p}': Permission denied`);
     } else {
-      console.error(`ls: ${target}: ${err?.message || "Error"}`);
+      console.error(`ls: ${p}: ${err?.message || "Error"}`);
     }
     hadError = true;
   }
@@ -52,5 +78,5 @@ if (hadError) process.exitCode = 1;
 // run only when executed directly
 const isDirect = import.meta.url === pathToFileURL(process.argv[1]).href;
 if (!isDirect) {
-  // allow import in tests without auto-running
+  // allow importing in tests without auto-executing
 }