swap top link to toc #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a fairly standard accessibility helper I don't think it's a good idea to remove, but def should link to the correct fragment!
❌ Deploy Preview for cyf-curriculum failed.
|
|
Makes sense! Looks good, but currently appears to scroll to the middle of the TOC rather than the top? Any idea why? This is what I see after scrolling down and clicking the link: 
|
|
Hrm. It's because there's a sticky header. The top of the toc is at the viewport now. I can fix that but it's a bit fiddly - let's merge this and open a style ticket. (this is actual function) |
post header height to other components
and post header height to outer css
Bugfix/toc scroll margin
|
I think this is obsoleted by #87? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a fairly standard accessibility helper I don't think it's a good idea to remove, but def should link to the correct fragment!
fixes #48