Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: mount Piscine module into ITP #744

Merged
merged 6 commits into from
Jun 6, 2024

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Jun 6, 2024

What does this change?

I've removed the Piscine dir from ITP and mounted in the new Piscine module. This means this will simply mirror whatever we do in our new Piscine site without ITP having to update it.

Checklist

Who needs to know about this?

Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 0e1ead9
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/6661c435fb80c700087a914c

Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 0e1ead9
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6661c435cecdb400075a3102
😎 Deploy Preview https://deploy-preview-744--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SallyMcGrath
Copy link
Member Author

Screenshot 2024-06-06 at 15 14 21

Copy link
Contributor

@Dedekind561 Dedekind561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Dedekind561 Dedekind561 merged commit 294ed41 into main Jun 6, 2024
9 of 10 checks passed
@Dedekind561 Dedekind561 deleted the feature/mount-piscine-into-itp branch June 6, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants